feat(stats): add C implementation for `stats/base/dists/degenerate/median` #4579

anandkaranubc · 2025-01-05T19:04:55Z

Resolves

#3541

Description

Purpose of this pull request

This pull request:

Adds a C implementation of the degenerate median.
Includes benchmarks for the C implementation.
Provides examples demonstrating the usage of the degenerate median in C.

Related Issues

Does this pull request have any related issues?

This pull request:

Resolves Issue #3541.

Questions

Any questions for reviewers of this pull request?

No.

Other Information

Any other relevant information?

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request:

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

stdlib-bot · 2025-01-05T19:07:14Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/degenerate/median	$\color{green}153/153$ $\color{green}+100.00\%$	$\color{green}5/5$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}153/153$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

anandkaranubc · 2025-01-08T06:42:29Z

/stdlib lint-autofix

anandkaranubc · 2025-01-08T06:42:33Z

Made the changes, taking feedback from #4593

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: na - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

…eneration --- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

Planeshifter

A few edits, otherwise should be ready to go.

Planeshifter · 2025-01-16T00:03:07Z

lib/node_modules/@stdlib/stats/base/dists/degenerate/median/src/main.c

+#include "stdlib/math/base/assert/is_nan.h"
+#include "stdlib/stats/base/dists/degenerate/median.h"


Suggested change

#include "stdlib/math/base/assert/is_nan.h"

#include "stdlib/stats/base/dists/degenerate/median.h"

#include "stdlib/stats/base/dists/degenerate/median.h"

#include "stdlib/math/base/assert/is_nan.h"

Planeshifter · 2025-01-16T00:04:07Z

...tdlib/stats/base/dists/degenerate/median/include/stdlib/stats/base/dists/degenerate/median.h

+/**
+* Returns the median of a degenerate distribution with constant value `mu`.
+*
+* @param mu   constant value of the distribution
+* @return     median of the distribution
+*/


Suggested change

/**

* Returns the median of a degenerate distribution with constant value `mu`.

*

* @param mu constant value of the distribution

* @return median of the distribution

*/

/**

* Returns the median of a degenerate distribution with constant value `mu`.

*/

anandkaranubc · 2025-01-16T00:07:10Z

A few edits, otherwise should be ready to go.

On it right now!

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: missing_dependencies - task: lint_c_benchmarks status: missing_dependencies - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: passed - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: passed - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

stdlib-bot · 2025-01-18T01:02:01Z

PR Commit Message

feat(stats): add C implementation for `stats/base/dists/degenerate/median`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4579
Ref: https://github.com/stdlib-js/stdlib/issues/3541

Co-authored-by: Karan Anand <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

PR-URL: stdlib-js#4579 Ref: stdlib-js#3541 Reviewed-by: Philipp Burckhardt <[email protected]>

anandkaranubc added 5 commits January 5, 2025 11:02

feat: add the C src files

7c63abb

feat: add the JS native files

670e177

feat: add the C benchmark and example files

369fe48

build: added the json and gyp dependency files

4838630

anandkaranubc changed the title ~~feat(stats): add C implementation for stats/base/dists/degenerate/mean~~ feat(stats): add C implementation for stats/base/dists/degenerate/median Jan 5, 2025

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 5, 2025

anandkaranubc marked this pull request as draft January 8, 2025 02:18

stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 8, 2025

stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Jan 8, 2025

anandkaranubc marked this pull request as ready for review January 8, 2025 06:50

stdlib-bot added the Needs Review A pull request which needs code review. label Jan 8, 2025

anandkaranubc added 3 commits January 8, 2025 19:15

Planeshifter approved these changes Jan 16, 2025

View reviewed changes

anandkaranubc added 2 commits January 15, 2025 16:12

anandkaranubc marked this pull request as draft January 16, 2025 00:31

stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 16, 2025

anandkaranubc marked this pull request as ready for review January 16, 2025 00:47

stdlib-bot added the Needs Review A pull request which needs code review. label Jan 16, 2025

Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jan 18, 2025

stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 18, 2025

Planeshifter merged commit 225b73b into stdlib-js:develop Jan 18, 2025
27 checks passed

anandkaranubc deleted the rfc/degen-median branch January 18, 2025 01:05

saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Jan 18, 2025

feat: add C implementation for stats/base/dists/degenerate/median

440e4f8

PR-URL: stdlib-js#4579 Ref: stdlib-js#3541 Reviewed-by: Philipp Burckhardt <[email protected]>

saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Jan 19, 2025

feat: add C implementation for stats/base/dists/degenerate/median

dc1a975

PR-URL: stdlib-js#4579 Ref: stdlib-js#3541 Reviewed-by: Philipp Burckhardt <[email protected]>

Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 23, 2025

feat: add C implementation for stats/base/dists/degenerate/median

3ef1659

PR-URL: stdlib-js#4579 Ref: stdlib-js#3541 Reviewed-by: Philipp Burckhardt <[email protected]>

Vinit-Pandit pushed a commit to Vinit-Pandit/stdlibMine that referenced this pull request Feb 4, 2025

feat: add C implementation for stats/base/dists/degenerate/median

910ef99

PR-URL: stdlib-js#4579 Ref: stdlib-js#3541 Reviewed-by: Philipp Burckhardt <[email protected]>

ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025

feat: add C implementation for stats/base/dists/degenerate/median

97604fd

PR-URL: stdlib-js#4579 Ref: stdlib-js#3541 Reviewed-by: Philipp Burckhardt <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(stats): add C implementation for `stats/base/dists/degenerate/median` #4579

feat(stats): add C implementation for `stats/base/dists/degenerate/median` #4579

Uh oh!

anandkaranubc commented Jan 5, 2025

Uh oh!

stdlib-bot commented Jan 5, 2025 •

edited

Loading

Uh oh!

anandkaranubc commented Jan 8, 2025

Uh oh!

anandkaranubc commented Jan 8, 2025

Uh oh!

Planeshifter left a comment

Uh oh!

Planeshifter Jan 16, 2025

Uh oh!

Planeshifter Jan 16, 2025

Uh oh!

anandkaranubc commented Jan 16, 2025

Uh oh!

stdlib-bot commented Jan 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		#include "stdlib/math/base/assert/is_nan.h"
		#include "stdlib/stats/base/dists/degenerate/median.h"

Uh oh!

feat(stats): add C implementation for stats/base/dists/degenerate/median #4579

feat(stats): add C implementation for stats/base/dists/degenerate/median #4579

Uh oh!

Conversation

anandkaranubc commented Jan 5, 2025

Resolves

Description

Purpose of this pull request

Related Issues

Does this pull request have any related issues?

Questions

Any questions for reviewers of this pull request?

Other Information

Any other relevant information?

Checklist

Uh oh!

stdlib-bot commented Jan 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

anandkaranubc commented Jan 8, 2025

Uh oh!

anandkaranubc commented Jan 8, 2025

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc commented Jan 16, 2025

Uh oh!

stdlib-bot commented Jan 18, 2025

PR Commit Message

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat(stats): add C implementation for `stats/base/dists/degenerate/median` #4579

feat(stats): add C implementation for `stats/base/dists/degenerate/median` #4579

stdlib-bot commented Jan 5, 2025 •

edited

Loading