-
-
Notifications
You must be signed in to change notification settings - Fork 907
feat: add C implementation for stats/base/dists/poisson/mgf
#4626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/stdlib update-copyright-years |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Signed-off-by: Philipp Burckhardt <[email protected]>
lib/node_modules/@stdlib/stats/base/dists/poisson/mgf/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/poisson/mgf/README.md
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/poisson/mgf/examples/c/example.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/poisson/mgf/benchmark/c/benchmark.c
Outdated
Show resolved
Hide resolved
Signed-off-by: Philipp Burckhardt <[email protected]>
lib/node_modules/@stdlib/stats/base/dists/poisson/mgf/examples/c/example.c
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/poisson/mgf/benchmark/c/benchmark.c
Show resolved
Hide resolved
Signed-off-by: Philipp Burckhardt <[email protected]>
/stdlib merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PR Commit Message
Please review the above commit message and make any necessary adjustments. |
t.end(); | ||
}); | ||
|
||
tape( 'if provided `+infinity` for `t` and a valid `lambda`, the function returns `+infinity`', opts, function test( t ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Planeshifter Why do these tests not match test.mgf.js
? The tolerances have also been increased. I suggest revisiting this test file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aligned the tolerances; but in this case, the native test file is actually more comprehensive (I had to do some clean-up before merge) and the main one incorrectly referred to x
parameter instead of t
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey please let me know if I can help
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AadishJ Thanks for the offer! Will ping you on any other open PRs should I see any discrepancies that we should look into. In this case, I mainly took the tests from the test.native.js
and updated the main test file accordingly, while then tweaking the names to avoid a reference to "range", since lambda should be referred to as the mean parameter.
Resolves #3791.
Description
This pull request:
Related Issues
This pull request:
@stdlib/stats/base/dists/poisson/mgf
#3791Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers