Skip to content

refactor: update math/base/assert/is-integer to follow latest project conventions #4627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2025
Merged

refactor: update math/base/assert/is-integer to follow latest project conventions #4627

merged 1 commit into from
Jan 19, 2025

Conversation

vivekmaurya001
Copy link
Contributor

Resolves None.

Description

  • refactoring addon.c to follow latest project conventions for math/base/assert/is-integer
  • updating benchmark calculations

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@vivekmaurya001
refactor: update math/base/assert/is-integer to follow latest project…
9527e8a 
… conventions

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: passed
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Jan 7, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/assert/is-integer $\color{green}143/143$
$\color{green}+100.00\%$ 		$\color{green}5/5$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}143/143$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Planeshifter
Planeshifter approved these changes Jan 19, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks, @vivekmaurya001!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jan 19, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 19, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

refactor: update `math/base/assert/is-integer` to follow latest project conventions

PR-URL: https://github.com/stdlib-js/stdlib/pull/4627

Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 3129e35 into stdlib-js:develop Jan 19, 2025
58 checks passed
saurabhraghuvanshii pushed a commit to saurabhraghuvanshii/stdlib-gs that referenced this pull request Jan 19, 2025
@vivekmaurya001 @saurabhraghuvanshii
refactor: update math/base/assert/is-integer to follow latest proje…
367fb8e 
…ct conventions

PR-URL: stdlib-js#4627

Reviewed-by: Philipp Burckhardt <[email protected]>
Neerajpathak07 pushed a commit to Neerajpathak07/stdlib that referenced this pull request Jan 23, 2025
@vivekmaurya001 @Neerajpathak07
refactor: update math/base/assert/is-integer to follow latest proje…
26da2df 
…ct conventions

PR-URL: stdlib-js#4627

Reviewed-by: Philipp Burckhardt <[email protected]>
Vinit-Pandit pushed a commit to Vinit-Pandit/stdlibMine that referenced this pull request Feb 4, 2025
@vivekmaurya001 @Vinit-Pandit
refactor: update math/base/assert/is-integer to follow latest proje…
8938a18 
…ct conventions

PR-URL: stdlib-js#4627

Reviewed-by: Philipp Burckhardt <[email protected]>
ShabiShett07 pushed a commit to ShabiShett07/stdlib that referenced this pull request Feb 26, 2025
@vivekmaurya001 @ShabiShett07
refactor: update math/base/assert/is-integer to follow latest proje…
d0739f2 
…ct conventions

PR-URL: stdlib-js#4627

Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vivekmaurya001 @stdlib-bot @Planeshifter