Skip to content

feat: add C implementation stats/base/dists/beta/mgf #4779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 23, 2025
Merged

feat: add C implementation stats/base/dists/beta/mgf #4779

merged 11 commits into from
Jun 23, 2025

Conversation

ShabiShett07
Copy link
Contributor

Resolves #3430 .

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 16, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 16, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/beta/mgf $\color{green}409/409$
$\color{green}+100.00\%$ 		$\color{green}24/24$
$\color{green}+100.00\%$ 		$\color{green}5/5$
$\color{green}+100.00\%$ 		$\color{green}409/409$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@ShabiShett07
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jan 16, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jan 16, 2025
@ShabiShett07
Copy link
Contributor Author

/stdlib lint-autofix

@stdlib-bot stdlib-bot added bot: In Progress Pull request is currently awaiting automation. and removed bot: In Progress Pull request is currently awaiting automation. labels Jan 16, 2025
@Planeshifter Planeshifter changed the title feat: add C implementation /stats/base/dists/beta/mgf feat: add C implementation stats/base/dists/beta/mgf Jan 18, 2025
@Planeshifter Planeshifter self-requested a review April 2, 2025 00:22
@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Apr 23, 2025
ShabiShett07 and others added 3 commits April 23, 2025 10:26
@ShabiShett07
Merge branch 'develop' into feature/beta/mgf
a842b6a 
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
chore: add indentation
de697be 
Signed-off-by: Shabareesh Shetty <[email protected]>
@ShabiShett07
chore: update implementation
3de9dfc 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: missing_dependencies
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
Planeshifter
Planeshifter reviewed Jun 9, 2025
View reviewed changes
Planeshifter
Planeshifter reviewed Jun 9, 2025
View reviewed changes
Planeshifter
Planeshifter reviewed Jun 9, 2025
View reviewed changes
Planeshifter
Planeshifter reviewed Jun 9, 2025
View reviewed changes
@ShabiShett07
Copy link
Contributor Author

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jun 10, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jun 10, 2025
@ShabiShett07
chore: update implementation
3a4041d 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: missing_dependencies
  - task: lint_c_examples
    status: missing_dependencies
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@ShabiShett07 @Planeshifter
chore: update variable order
1063878 
Co-authored-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>
@Planeshifter
fix: modernize PRNG usage and fix C variable order in beta/mgf
eb1579e 
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: na
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: na
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
Planeshifter
Planeshifter reviewed Jun 23, 2025
View reviewed changes
Planeshifter
Planeshifter approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ready now. Thanks, @ShabiShett07!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jun 23, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jun 23, 2025 •
edited by Planeshifter
Loading

PR Commit Message

feat: add C implementation `stats/base/dists/beta/mgf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/4779
Closes: https://github.com/stdlib-js/stdlib/issues/3430

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>

Please review the above commit message and make any necessary adjustments.

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jun 23, 2025
@Planeshifter Planeshifter merged commit 59e3497 into stdlib-js:develop Jun 23, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/stats/base/dists/beta/mgf

3 participants

@ShabiShett07 @stdlib-bot @Planeshifter