-
-
Notifications
You must be signed in to change notification settings - Fork 907
feat: add math/base/special/sind
#487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lib/node_modules/@stdlib/math/base/special/sind/test/fixtures/julia/all_tests.json
Outdated
Show resolved
Hide resolved
@AlisaLC You mind checking the box above to indicate that you've read the contributing guidelines? In particular, checking this box means agreeing to the licensing terms. |
Done. but if i remember correctly, a few of the tests didn't pass by narrow margins which were normal sin tests but for some reason kernel sin was not as accurate! |
@AlisaLC Thanks! Yeah, kernel sine is sensitive to argument scaling. I'll take a look. |
/stdlib merge |
math/base/special/sind
@gunjjoshi Do you think you'd be up for taking over this PR? |
@kgryte Sure, I'll take this over. |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Ref: #5435 |
Thank you for working on this pull request. However, we cannot accept your contribution as the issue this pull request seeks to resolve has already been addressed in a different pull request or commit. Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions. |
Resolves #32
Description
This pull request:
Related Issues
This pull request:
math/base/special/sind
#32Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers