Skip to content

chore: address commit comment feedback #5078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 6, 2025
Merged

chore: address commit comment feedback #5078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
387b820
fixed #5052
MohammadBinAftab Feb 4, 2025
09156f3
Merge branch 'stdlib-js:develop' into develop
MohammadBinAftab Feb 6, 2025
00e35e3
Fixed #5073
MohammadBinAftab Feb 6, 2025
1b2f027
chore: apply suggestions from code review
Planeshifter Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions lib/node_modules/@stdlib/blas/ext/base/dsortins/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ stdlib_strided_dsortins( 2, -1.0, x, 1 );
The function accepts the following arguments:

- **N**: `[in] CBLAS_INT` number of indexed elements.
- **order**: `[in] double` sort order. If `order < 0.0`, the input strided array `x` is sorted in **decreasing** order. If `order > 0.0`, the input strided array `x` is sorted in **increasing** order. If `order == 0.0`, the input strided arrays are left unchanged.
- **order**: `[in] double` sort order. If `order < 0.0`, the input strided array is sorted in **decreasing** order. If `order > 0.0`, the input strided array is sorted in **increasing** order. If `order == 0.0`, the input strided array is left unchanged.
- **X**: `[inout] double*` input array.
- **strideX**: `[in] CBLAS_INT` stride length for `X`.

Expand All @@ -206,7 +206,7 @@ stdlib_strided_dsortins_ndarray( 4, 1.0, x, 1, 0 );
The function accepts the following arguments:

- **N**: `[in] CBLAS_INT` number of indexed elements.
- **order**: `[in] double` sort order. If `order < 0.0`, the input strided array `x` is sorted in **decreasing** order. If `order > 0.0`, the input strided array `x` is sorted in **increasing** order. If `order == 0.0`, the input strided arrays are left unchanged.
- **order**: `[in] double` sort order. If `order < 0.0`, the input strided array is sorted in **decreasing** order. If `order > 0.0`, the input strided array is sorted in **increasing** order. If `order == 0.0`, the input strided array is left unchanged.
- **X**: `[inout] double*` input array.
- **strideX**: `[in] CBLAS_INT` stride length for `X`.
- **offsetX**: `[in] CBLAS_INT` starting index for `X`.
Expand Down Expand Up @@ -255,7 +255,6 @@ int main( void ) {
printf( "x[ %i ] = %lf\n", i, x[ i ] );
}
}

```

</section>
Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/blas/ext/base/dsortins/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ void API_SUFFIX(stdlib_strided_dsortins_ndarray)( const CBLAS_INT N, const doubl
ox = offsetX;
}
fx = ox;
lx = fx + (N-1) * sx;
lx = fx + ( (N-1) * sx );
ix = fx + sx;
if ( sx < 0 ) {
// Traverse the strided array from right-to-left...
Expand Down
Loading