Skip to content

chore: address commit comments for betaprime/mode #5080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2025
Merged

chore: address commit comments for betaprime/mode #5080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/node_modules/@stdlib/stats/base/dists/betaprime/mode/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ Returns the mode of a beta prime distribution with first shape parameter `alpha`

```c
double y = stdlib_base_dists_betaprime_mode( 1.0, 2.0 );
//returns ~0.0
//returns 0.0
```

The function accepts the following arguments:
Expand Down Expand Up @@ -228,7 +228,7 @@ int main( void ) {
alpha = random_uniform( STDLIB_CONSTANT_FLOAT64_EPS, 10.0 );
beta = random_uniform( 1.0 + STDLIB_CONSTANT_FLOAT64_EPS, 11.0 );
y = stdlib_base_dists_betaprime_mode( alpha, beta );
printf( "α: %1f, β: %1f, Mode(X;α,β): %lf\n", alpha, beta, y );
printf( "α: %lf, β: %lf, Mode(X;α,β): %lf\n", alpha, beta, y );
}
}
```
Expand Down
4 changes: 1 addition & 3 deletions lib/node_modules/@stdlib/stats/base/dists/betaprime/mode/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,9 @@ bench( pkg, function benchmark( b ) {

len = 100;
alpha = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
alpha[ i ] = uniform( EPS, 10.0 );
}
beta = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
alpha[ i ] = uniform( EPS, 10.0 );
beta[ i ] = uniform( EPS, 10.0 );
}

Expand Down
4 changes: 1 addition & 3 deletions lib/node_modules/@stdlib/stats/base/dists/betaprime/mode/benchmark/benchmark.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,9 @@ bench( pkg+'::native', opts, function benchmark( b ) {

len = 100;
alpha = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
alpha[ i ] = uniform( EPS, 10.0 );
}
beta = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
alpha[ i ] = uniform( EPS, 10.0 );
beta[ i ] = uniform( EPS, 10.0 );
}

Expand Down
2 changes: 0 additions & 2 deletions lib/node_modules/@stdlib/stats/base/dists/betaprime/mode/benchmark/c/benchmark.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,6 @@ static double benchmark( void ) {

for ( i = 0; i < 100; i++ ) {
alpha[ i ] = random_uniform( STDLIB_CONSTANT_FLOAT64_EPS, 10.0 );
}
for ( i = 0; i < 100; i++ ) {
beta[ i ] = random_uniform( STDLIB_CONSTANT_FLOAT64_EPS, 10.0 );
}

Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/stats/base/dists/betaprime/mode/examples/c/example.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,6 @@ int main( void ) {
alpha = random_uniform( STDLIB_CONSTANT_FLOAT64_EPS, 10.0 );
beta = random_uniform( 1.0 + STDLIB_CONSTANT_FLOAT64_EPS, 11.0 );
y = stdlib_base_dists_betaprime_mode( alpha, beta );
printf( "α: %1f, β: %1f, Mode(X;α,β): %lf\n", alpha, beta, y );
printf( "α: %lf, β: %lf, Mode(X;α,β): %lf\n", alpha, beta, y );
}
}
6 changes: 3 additions & 3 deletions lib/node_modules/@stdlib/stats/base/dists/betaprime/mode/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@
* @param x input value
* @param alpha first shape parameter
* @param beta second shape parameter
* @returns mode
* @return mode
*
* @example
* double y = stdlib_base_dists_betaprime_mode( 1.0, 2.0 );
* // returns ~0.0
* // returns 0.0
*/
double stdlib_base_dists_betaprime_mode( double alpha, const double beta ) {
double stdlib_base_dists_betaprime_mode( const double alpha, const double beta ) {
if ( alpha <= 0.0 || beta <= 0.0 ) {
return 0.0 / 0.0;
}
Expand Down