Skip to content

Conversation

@ekambains
Copy link
Contributor

@ekambains ekambains commented Feb 7, 2025

Resolves #5095.

Description

What is the purpose of this pull request?

This pull request:

  • Fixes the typos as per the request.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Feb 7, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 7, 2025

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/degenerate/entropy $\color{green}161/161$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}161/161$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first PR to stdlib! 🙏

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Feb 8, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 8, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

Refactored according to comments

PR-URL: https://github.com/stdlib-js/stdlib/pull/5103
Closes: https://github.com/stdlib-js/stdlib/issues/5095

Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: ekambains <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>
Signed-off-by: ekambains <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter
Copy link
Member

Looks like this was already addressed in another PR; closing this one out. Thanks either way!

@ekambains ekambains deleted the comments/degenerate-entropy branch February 10, 2025 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address commit comments (commit 78c8b3c)

3 participants