Skip to content

bench: refactor random number generation in stats/base/dists/laplace #5270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 5, 2025
Merged

bench: refactor random number generation in stats/base/dists/laplace #5270

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b8e2d64
bench: refactor random number generation in JS benchmarks for stats/b…
gkbishnoi07 Feb 17, 2025
49584f1
Merge branch 'develop' of github.com:gkbishnoi07/stdlib into issue-4976
gkbishnoi07 Feb 21, 2025
263c7ce
applied changes
gkbishnoi07 Feb 21, 2025
0fff553
changes applied
gkbishnoi07 Mar 3, 2025
b6cf258
refactor: apply suggested change to dist.b condition
gkbishnoi07 Mar 3, 2025
3890967
Refactor benchmark.js to ensure consistency
gkbishnoi07 Mar 4, 2025
922656b
Refactor benchmark.js to ensure consistency
gkbishnoi07 Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions lib/node_modules/@stdlib/stats/base/dists/laplace/cdf/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
// MODULES //

var bench = require( '@stdlib/bench' );
var randu = require( '@stdlib/random/base/randu' );
var Float64Array = require( '@stdlib/array/float64' );
var uniform = require( '@stdlib/random/base/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var EPS = require( '@stdlib/constants/float64/eps' );
var pkg = require( './../package.json' ).name;
Expand All @@ -32,17 +33,25 @@ var cdf = require( './../lib' );

bench( pkg, function benchmark( b ) {
var scale;
var len;
var mu;
var x;
var y;
var i;

len = 100;
mu = new Float64Array( len );
scale = new Float64Array( len );
x = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
x[ i ] = uniform( -100.0, 100.0 );
mu[ i ] = uniform( -50.0, 50.0 );
scale[ i ] = uniform( EPS, 20.0 );
}

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = ( randu()*200.0 ) - 100;
mu = ( randu()*100.0 ) - 50.0;
scale = ( randu()*20.0 ) + EPS;
y = cdf( x, mu, scale );
y = cdf( x[ i % len ], mu[ i % len ], scale[ i % len ] );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand All @@ -58,19 +67,24 @@ bench( pkg, function benchmark( b ) {
bench( pkg+':factory', function benchmark( b ) {
var mycdf;
var scale;
var len;
var mu;
var x;
var y;
var i;

mu = 0.0;
scale = 1.5;
len = 100;
x = new Float64Array( len );
mycdf = cdf.factory( mu, scale );
for ( i = 0; i < len; i++ ) {
x[ i ] = uniform( -2.0, 2.0 );
}

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
x = ( randu()*4.0 ) - 2.0;
y = mycdf( x );
y = mycdf( x[ i % len ] );
if ( isnan( y ) ) {
b.fail( 'should not return NaN' );
}
Expand Down
Loading