Skip to content

Conversation

rishavtarway
Copy link
Contributor

Resolves #5228 .

Description

What is the purpose of this pull request?

This pull request:address the commit comments of (commit fb90f93)

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

Hi, reviewers! Could you please check if I have followed the contributing guidelines properly? If there are any mistakes or areas for improvement in my code or approach, I would appreciate your feedback. I'm open to suggestions for making it better!

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

…ples

- Reverts manual array population to use optimized array API
- Aligns sample size with commit fb90f93 specifications
- Improves statistical validity of benchmark results
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Feb 18, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Feb 18, 2025

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/planck/median $\color{green}163/163$
$\color{green}+100.00\%$
$\color{green}8/8$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}163/163$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Feb 19, 2025
@kgryte kgryte changed the title Chore : Address Commit Comments Regarding mathematical and technical Justification chore: address commit comments Feb 19, 2025
@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 19, 2025
@rishavtarway rishavtarway requested a review from kgryte February 19, 2025 05:39
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 19, 2025
@rishavtarway
Copy link
Contributor Author

@kgryte @anandkaranubc can you review the changes now ?

@anandkaranubc
Copy link
Contributor

@kgryte @anandkaranubc can you review the changes now ?

@rishavtarway, I don't see any changed files in this PR.

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Changes Pull request which needs changes before being merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address commit comments (commit fb90f93)

4 participants