-
-
Notifications
You must be signed in to change notification settings - Fork 908
chore: address commit comments #5288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ples - Reverts manual array population to use optimized array API - Aligns sample size with commit fb90f93 specifications - Improves statistical validity of benchmark results
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
reviewed
Feb 19, 2025
lib/node_modules/@stdlib/stats/base/dists/planck/median/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
kgryte
reviewed
Feb 19, 2025
lib/node_modules/@stdlib/stats/base/dists/planck/median/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
@kgryte @anandkaranubc can you review the changes now ? |
@rishavtarway, I don't see any changed files in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs Changes
Pull request which needs changes before being merged.
Statistics
Issue or pull request related to statistical functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5228 .
Description
This pull request:address the commit comments of (commit fb90f93)
fb90f93
) #5228Related Issues
This pull request:
fb90f93
) #5228Questions
Hi, reviewers! Could you please check if I have followed the contributing guidelines properly? If there are any mistakes or areas for improvement in my code or approach, I would appreciate your feedback. I'm open to suggestions for making it better!
Other
No.
Checklist
@stdlib-js/reviewers