Skip to content

chore: address commit comments #5288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

chore: address commit comments #5288

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13096eb
refactor(benchmark): Standardize to random/array/uniform and 1000 sam…
rishavtarway Feb 18, 2025
d80ce2d
made changes to assigned task
rishavtarway Feb 19, 2025
8343e9f
removed the duplicate logic as suggested
rishavtarway Feb 19, 2025
0b44716
removed the randu which is not being utilised here
rishavtarway Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/node_modules/@stdlib/stats/base/dists/planck/median/benchmark/benchmark.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
var bench = require( '@stdlib/bench' );
var Float64Array = require( '@stdlib/array/float64' );
var uniform = require( '@stdlib/random/base/uniform' );
var randu = require( '@stdlib/random/array/uniform' );
var isnan = require( '@stdlib/math/base/assert/is-nan' );
var pkg = require( './../package.json' ).name;
var median = require( './../lib' );
Expand All @@ -42,6 +43,8 @@ bench( pkg, function benchmark( b ) {
lambda[ i ] = uniform( 1.0, 10.0);
}

lambda = randu( len, 1.0, 10.0 );

b.tic();
for ( i = 0; i < b.iterations; i++ ) {
y = median( lambda[ i % len ] );
Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/stats/base/dists/planck/median/benchmark/benchmark.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ bench( pkg+'::native', opts, function benchmark( b ) {
var y;
var i;

len = 100;
len = 1000; // Standardized sample size for statistical significance
lambda = new Float64Array( len );
for ( i = 0; i < len; i++ ) {
lambda[ i ] = uniform( 1.0, 10.0 );
Expand Down
Loading