Skip to content

chore: address commit comments #5320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2025
Merged

chore: address commit comments #5320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
46d1c5d
chore: addresses commit comments
saurabhraghuvanshii Feb 19, 2025
6467d6a
Merge branch 'stdlib-js:develop' into uniform-stdev
saurabhraghuvanshii Feb 23, 2025
284d56c
bench: add opts
saurabhraghuvanshii Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions lib/node_modules/@stdlib/stats/base/dists/uniform/stdev/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,9 @@

'use strict';

// MODULES //

var sqrt = require( '@stdlib/math/base/special/sqrt' );


// VARIABLES //

var SQRT1O12 = sqrt( 1.0/12.0 );
var SQRT1O12 = 0.28867513459481287; // sqrt( 1.0/12.0 );


// MAIN //
Expand Down
6 changes: 4 additions & 2 deletions lib/node_modules/@stdlib/stats/base/dists/uniform/stdev/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@

#include "stdlib/stats/base/dists/uniform/stdev.h"
#include "stdlib/math/base/assert/is_nan.h"
#include "stdlib/math/base/special/sqrt.h"

/**
* Returns the standard deviation of a uniform distribution.
Expand All @@ -31,6 +30,9 @@
* double v = stdev( 4.0, 12.0 );
* // returns ~2.309
*/

static const double SQRT_ONE_TWELFTH = 0.28867513459481287; // stdlib_base_sqrt( 1.0/12.0 )

double stdlib_base_dists_uniform_stdev( const double a, const double b ) {
if (
stdlib_base_is_nan( a ) ||
Expand All @@ -39,5 +41,5 @@ double stdlib_base_dists_uniform_stdev( const double a, const double b ) {
) {
return 0.0 / 0.0; // NaN
}
return stdlib_base_sqrt( 1.0/12.0 ) * ( b-a );
return SQRT_ONE_TWELFTH * ( b-a );
}
10 changes: 3 additions & 7 deletions lib/node_modules/@stdlib/stats/base/dists/uniform/stdev/test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,9 @@ tape( 'the function returns the standard deviation of a uniform distribution', f
b = data.b;
for ( i = 0; i < expected.length; i++ ) {
y = stdev( a[i], b[i] );
if ( y === expected[i] ) {
t.equal( y, expected[i], 'a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] );
} else {
delta = abs( y - expected[ i ] );
tol = 1.0 * EPS * abs( expected[ i ] );
t.ok( delta <= tol, 'within tolerance. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' );
}
delta = abs( y - expected[ i ] );
tol = 1.0 * EPS * abs( expected[ i ] );
t.ok( delta <= tol, 'within tolerance. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' );
}
t.end();
});
12 changes: 4 additions & 8 deletions lib/node_modules/@stdlib/stats/base/dists/uniform/stdev/test/test.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ tape( 'if provided `a >= b`, the function returns `NaN`', opts, function test( t
t.end();
});

tape( 'the function returns the standard deviation of a uniform distribution', function test( t ) {
tape( 'the function returns the standard deviation of a uniform distribution', opts, function test( t ) {
var expected;
var delta;
var tol;
Expand All @@ -93,13 +93,9 @@ tape( 'the function returns the standard deviation of a uniform distribution', f
b = data.b;
for ( i = 0; i < expected.length; i++ ) {
y = stdev( a[i], b[i] );
if ( y === expected[i] ) {
t.equal( y, expected[i], 'a: '+a[i]+', b: '+b[i]+', y: '+y+', expected: '+expected[i] );
} else {
delta = abs( y - expected[ i ] );
tol = 1.0 * EPS * abs( expected[ i ] );
t.ok( delta <= tol, 'within tolerance. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' );
}
delta = abs( y - expected[ i ] );
tol = 1.0 * EPS * abs( expected[ i ] );
t.ok( delta <= tol, 'within tolerance. a: '+a[i]+'. b: '+b[i]+'. y: '+y+'. E: '+expected[ i ]+'. Δ: '+delta+'. tol: '+tol+'.' );
}
t.end();
});
Loading