-
-
Notifications
You must be signed in to change notification settings - Fork 996
bench: refactor random number generation in stats/base/dists/weibull
#5342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… JS benchmarks
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: na
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
- task: run_javascript_examples
status: na
- task: run_c_examples
status: na
- task: run_cpp_examples
status: na
- task: run_javascript_readme_examples
status: na
- task: run_c_benchmarks
status: na
- task: run_cpp_benchmarks
status: na
- task: run_fortran_benchmarks
status: na
- task: run_javascript_benchmarks
status: na
- task: run_julia_benchmarks
status: na
- task: run_python_benchmarks
status: na
- task: run_r_benchmarks
status: na
- task: run_javascript_tests
status: na
---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Contributor
Author
|
@anandkaranubc please review this PR |
Planeshifter
approved these changes
Mar 5, 2025
Member
Planeshifter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks much, @G4URAV001!
Contributor
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Good First PR
A pull request resolving a Good First Issue.
Ready To Merge
A pull request which is ready to be merged.
Statistics
Issue or pull request related to statistical functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… JS benchmarks
Resolves #4992 .
Description
This pull request:
This pull request improves random number generation in JS benchmarks for stats/base/dists/weibull. Specifically:
Moves random number generation out of benchmarking loops to prevent interference with benchmark results.
Uses @stdlib/random/base/uniform and @stdlib/random/base/discrete-uniform instead of randu expressions.
Ensures generated random values maintain the same range as existing values for consistency.
Related Issues
References #4837 and #4955 as examples of similar improvements.
This pull request:
stats/base/dists/weibull#4992Questions
No.
Other
No.
Checklist
✅ Build Native Add-on.
✅ Run JavaScript Benchmarks.
✅ Run JavaScript Native Benchmarks.
@stdlib-js/reviewers