bench: refactor random number generation #5397

saurabhraghuvanshii · 2025-02-23T18:30:13Z

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

Refactors random number generation in JS benchmark in math/base/special/besselj*

Related Issues

Does this pull request have any related issues?

This pull request:

resolves none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

stdlib-bot · 2025-02-23T18:33:31Z

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/besselj0	$\color{red}491/501$ $\color{green}+98.00\%$	$\color{red}40/46$ $\color{green}+86.96\%$	$\color{green}6/6$ $\color{green}+100.00\%$	$\color{red}491/501$ $\color{green}+98.00\%$
math/base/special/besselj1	$\color{red}499/507$ $\color{green}+98.42\%$	$\color{red}42/48$ $\color{green}+87.50\%$	$\color{green}6/6$ $\color{green}+100.00\%$	$\color{red}499/507$ $\color{green}+98.42\%$
math/base/special/bessely0	$\color{red}586/599$ $\color{green}+97.83\%$	$\color{red}45/54$ $\color{green}+83.33\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{red}586/599$ $\color{green}+97.83\%$
math/base/special/bessely1	$\color{red}455/463$ $\color{green}+98.27\%$	$\color{red}39/45$ $\color{green}+86.67\%$	$\color{green}5/5$ $\color{green}+100.00\%$	$\color{red}455/463$ $\color{green}+98.27\%$
math/base/special/beta	$\color{red}326/339$ $\color{green}+96.17\%$	$\color{red}28/35$ $\color{green}+80.00\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{red}326/339$ $\color{green}+96.17\%$

The above coverage report was generated for the changes in this PR.

anandkaranubc · 2025-02-24T04:14:29Z

@saurabhraghuvanshii Thanks for working on this. If you're already covering the functions from the top, I'll start from the bottom to avoid duplicate PRs. 😄

saurabhraghuvanshii · 2025-02-24T04:15:54Z

Yes I am covering from top , thanks

anandkaranubc

Just some minor changes :)

anandkaranubc · 2025-02-26T14:44:34Z

lib/node_modules/@stdlib/math/base/special/besselj0/benchmark/c/native/benchmark.c

 	int i;

+	for ( i = 0; i < 100; i++ ) {
+		x[ i ] = ( 100000.0 * rand_double() ) - 0.0;


Suggested change

x[ i ] = ( 100000.0 * rand_double() ) - 0.0;

x[ i ] = 100000.0 * rand_double();

so many file have this so can I remove this type things that file too?

Let's apply this change to the packages we've already refactored. For the remaining packages, we can implement this change along with other refactoring tasks.

But yes, this type of change is desired in all the upcoming PRs.

Today I do refactor for other files also , I have my end sem exam therefore, I am busy

No rush! I don't think this is a high-priority change....

lib/node_modules/@stdlib/math/base/special/besselj1/benchmark/c/native/benchmark.c

lib/node_modules/@stdlib/math/base/special/bessely0/benchmark/c/native/benchmark.c

lib/node_modules/@stdlib/math/base/special/beta/benchmark/c/cephes/benchmark.c

lib/node_modules/@stdlib/math/base/special/beta/benchmark/c/native/benchmark.c

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: failed ---

anandkaranubc · 2025-02-26T16:48:53Z

@kgryte This should be ready to merge.

stdlib-bot · 2025-03-01T13:31:39Z

PR Commit Message

bench: refactor random number generation

PR-URL: https://github.com/stdlib-js/stdlib/pull/5397

Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: saurabhraghuvanshii <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Feb 23, 2025

anandkaranubc added the Benchmarks Pull requests adding or improving benchmarks for measuring performance. label Feb 24, 2025

kgryte requested a review from anandkaranubc February 25, 2025 22:18

anandkaranubc requested changes Feb 26, 2025

View reviewed changes

anandkaranubc added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Feb 26, 2025

saurabhraghuvanshii added 2 commits February 26, 2025 21:28

Merge branch 'stdlib-js:develop' into random-refactor

54eca44

anandkaranubc removed the Needs Changes Pull request which needs changes before being merged. label Feb 26, 2025

Planeshifter approved these changes Mar 1, 2025

View reviewed changes

Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 1, 2025

Planeshifter merged commit 52c0299 into stdlib-js:develop Mar 1, 2025
26 checks passed

saurabhraghuvanshii deleted the random-refactor branch March 1, 2025 16:32

	x[ i ] = ( 100000.0 * rand_double() ) - 0.0;
	x[ i ] = 100000.0 * rand_double();

Uh oh!

bench: refactor random number generation #5397

bench: refactor random number generation #5397

Uh oh!

Conversation

saurabhraghuvanshii commented Feb 23, 2025

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Feb 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

anandkaranubc commented Feb 24, 2025

Uh oh!

saurabhraghuvanshii commented Feb 24, 2025

Uh oh!

anandkaranubc left a comment

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Feb 26, 2025

Choose a reason for hiding this comment

Uh oh!

saurabhraghuvanshii Feb 26, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Feb 26, 2025

Choose a reason for hiding this comment

Uh oh!

saurabhraghuvanshii Feb 26, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Feb 26, 2025

Choose a reason for hiding this comment

Uh oh!

saurabhraghuvanshii Feb 26, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Feb 26, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anandkaranubc commented Feb 26, 2025

Uh oh!

stdlib-bot commented Mar 1, 2025

PR Commit Message

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

stdlib-bot commented Feb 23, 2025 •

edited

Loading