-
-
Notifications
You must be signed in to change notification settings - Fork 907
updated comments #5520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated comments #5520
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -171,7 +171,7 @@ Evaluates the [cumulative distribution function][cdf] (CDF) for a [Cauchy][cauch | |||
|
||||
```c | ||||
double out = stdlib_base_dists_cauchy_cdf( 0.5, 0.0, 2.0 ); | ||||
// returns ~0.333 | ||||
// returns ~0.578 | ||||
``` | ||||
|
||||
The function accepts the following arguments: | ||||
|
@@ -213,9 +213,10 @@ static double random_uniform( const double min, const double max ) { | |||
} | ||||
|
||||
int main( void ) { | ||||
//correct order based on the length | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||
double gamma; | ||||
double x; | ||||
double x0; | ||||
double x; | ||||
double y; | ||||
int i; | ||||
|
||||
|
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -31,10 +31,10 @@ var pkg = require( './../package.json' ).name; | |||
|
||||
|
||||
// VARIABLES // | ||||
|
||||
var logcdf = tryRequire( resolve( __dirname, './../lib/native.js' ) ); | ||||
//corected variable name | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||
var cdf = tryRequire( resolve( __dirname, './../lib/native.js' ) ); | ||||
var opts = { | ||||
'skip': ( logcdf instanceof Error ) | ||||
'skip': ( cdf instanceof Error ) | ||||
}; | ||||
|
||||
|
||||
|
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -26,11 +26,13 @@ static double random_uniform( const double min, const double max ) { | |||
} | ||||
|
||||
int main( void ) { | ||||
double gamma; | ||||
//corrected order | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @ChaitraTM This order is not correct. The order should be in order of decreasing length, not increasing length. |
||||
int i; | ||||
double x; | ||||
double x0; | ||||
double y; | ||||
int i; | ||||
double x0; | ||||
double gamma; | ||||
ChaitraTM marked this conversation as resolved.
Show resolved
Hide resolved
|
||||
|
||||
|
||||
for ( i = 0; i < 25; i++ ) { | ||||
x = random_uniform( 0.0, 10.0 ); | ||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments here and elsewhere in this PR need to be removed.