bench: update random value generation

[anandkaranubc]

Resolves none.

Description

What is the purpose of this pull request?

This pull request:

• Refactors random number generation in JS benchmarks for the remaining math/base/special/tan* packages
• Replaces randu() with uniform() from @stdlib/random/array/uniform for cleaner and more consistent code.
• Moves the random number generation outside the benchmarking loops.
• Updates the test messages to follow code conventions.

Related Issues

Does this pull request have any related issues?

This pull request:

• resolves none

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines.

---

@stdlib-js/reviewers

[stdlib-bot]

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/tan	$\color{green}229/229$ $\color{green}+100.00\%$	$\color{green}11/11$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}229/229$ $\color{green}+100.00\%$
math/base/special/tand	$\color{green}183/183$ $\color{green}+100.00\%$	$\color{green}11/11$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}183/183$ $\color{green}+100.00\%$
math/base/special/tanh	$\color{red}297/298$ $\color{green}+99.66\%$	$\color{red}23/24$ $\color{green}+95.83\%$	$\color{green}3/3$ $\color{green}+100.00\%$	$\color{red}297/298$ $\color{green}+99.66\%$

The above coverage report was generated for the changes in this PR.

[Planeshifter]

LGTM!

[stdlib-bot]

PR Commit Message

bench: update random value generation

PR-URL: https://github.com/stdlib-js/stdlib/pull/5528

Co-authored-by: Karan Anand <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

[anandkaranubc]

@Planeshifter I had a question about the test coverage for math/base/special/tanh. The only reason it doesn't have a 100% test coverage is because this block:

stdlib/lib/node_modules/@stdlib/math/base/special/tanh/lib/rational_pq.js

Lines 45 to 46 in a62261a

	if ( x < 0.0 ) {
	ax = -x;

never gets executed as the function is always called on s >= 0 over here:

stdlib/lib/node_modules/@stdlib/math/base/special/tanh/lib/main.js

Lines 115 to 116 in a62261a

	s = x * x;
	z = x + ( x*s*ratval( s ) );

Do you think it can be removed or was this intentionally placed? I am sorry if I am missing something. Thanks!

[kgryte]

@anandkaranubc That is fine. That function is auto-generated. We don't need to be mucking about with removing code blocks in this case.

[kgryte]

I suppose one thing we could do, however, is leave a comment indicating that it is okay if a branch in a polval or ratval function doesn't get reached. Eventually, we'll be auto-creating issues on the project repository for increasing code coverage.

That said, this is probably something we should keep in mind @Planeshifter. If we detect that one of these auto-generated files doesn't have full code coverage, we can likely safely ignore and not create a code coverage issue.

[anandkaranubc]

@anandkaranubc That is fine. That function is auto-generated. We don't need to be mucking about with removing code blocks in this case.

Thanks, that makes sense. My next aim after the math/base/special refactoring was to improve the test coverage for as many files as possible. I believe this is being leveraged for good first issues then 👍

[kgryte]

@anandkaranubc Yeah, there may be some trickier ones. E.g., beta and friends. Those are likely not good first issues.

[anandkaranubc]

Makes me wonder if hyp2f1 is also in the list..... 🙃