Skip to content

Fix comments in hypergeometric logpmf #5768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix comments in hypergeometric logpmf #5768

wants to merge 1 commit into from

Conversation

prince04-coder
Copy link

@prince04-coder prince04-coder commented Mar 3, 2025 •
edited
Loading

Fixes #5747

Address commit comments in 11e8a56.

  • Remove extra space between logpmf and ( in lib/node_modules/@stdlib/stats/base/dists/hypergeometric/logpmf/README.md.
  • Add Oxford comma after K and before and in lib/node_modules/@stdlib/stats/base/dists/hypergeometric/logpmf/src/main.c.
  • Change test description to "returns expected value" in lib/node_modules/@stdlib/stats/base/dists/hypergeometric/logpmf/test/test.native.js.

For more details, open the Copilot Workspace session.

@prince04-coder
Fix comments in hypergeometric logpmf
dc1d4ec 
Fixes stdlib-js#5747

Address commit comments in `11e8a56`.

* Remove extra space between `logpmf` and `(` in `lib/node_modules/@stdlib/stats/base/dists/hypergeometric/logpmf/README.md`.
* Add Oxford comma after `K` and before `and` in `lib/node_modules/@stdlib/stats/base/dists/hypergeometric/logpmf/src/main.c`.
* Change test description to "returns expected value" in `lib/node_modules/@stdlib/stats/base/dists/hypergeometric/logpmf/test/test.native.js`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/stdlib-js/stdlib/issues/5747?shareId=XXXX-XXXX-XXXX-XXXX).
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 3, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

1 similar comment
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Mar 3, 2025
stdlib-bot
stdlib-bot reviewed Mar 3, 2025
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@Planeshifter Planeshifter added the autoclose: Spam Pull request which should be auto-closed as considered spam. label Mar 5, 2025
@stdlib-bot
Copy link
Contributor

Thank you for working on this pull request. However, we cannot accept your contribution as this pull request does not meet the standards of this project.

Thank you again for your interest in stdlib, and we look forward to reviewing your future contributions.

@stdlib-bot stdlib-bot closed this Mar 5, 2025
@stdlib-js stdlib-js locked as spam and limited conversation to collaborators Mar 5, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stdlib-bot stdlib-bot stdlib-bot left review comments

Assignees

No one assigned

Labels

autoclose: Spam Pull request which should be auto-closed as considered spam. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Address commit comments (commit 11e8a56)

3 participants

@prince04-coder @stdlib-bot @Planeshifter