Skip to content

Conversation

ChaitraTM
Copy link

Resolves #5712.

Description

What is the purpose of this pull request?

This pull request:

  • updates the normal quantile implementation to use STDLIB_CONSTANT_FLOAT64_SQRT_TWO instead of recalculating sqrt(2) each time. This improves efficiency and maintains consistency with similar implementations.

Related Issues

  • {{TODO: add description describing what this pull request does}}

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 4, 2025
@Planeshifter
Copy link
Member

Going to merge #5763 instead. Please take a look for the changes that were expected.

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address commit comments (commit 1f5d85a)

3 participants