Skip to content

Conversation

akash8843
Copy link

Resolves #7141f46

Description

This pull request fixes the missing section in the README file and adds necessary updates to main.c.

Related Issues

  • Related to issue #7141f46

Questions

  • No questions for now.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 6, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 6, 2025

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/geometric/cdf $\color{green}291/291$
$\color{green}+100.00\%$
$\color{green}27/27$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}291/291$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

#### cdf.factory( p )

Returns a function for evaluating the [cumulative distribution function][cdf] of a [geometric][geometric-distribution] distribution with success probability `p`
Returns a function for evaluating the [cumulative distribution function][cdf] of a [geometric][geometric-distribution] distribution with success probability `p`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"I added a period at the end to follow proper documentation style. If this change is not required, please let me know — I’ll revert it."

@akash8843
Copy link
Author

Hello @kgryte, 👋

I hope you are doing well!

I have created a pull request to fix the missing section in the README and main.c file for the stdlib-js project:

🔗 PR Link: (akash8843:fix-missing-section-7141f46)]

I would really appreciate it if you could review my PR whenever you have some time. Your feedback will help me improve and learn more!

Thank you so much for your guidance and support! 🙏

Best regards,
Akash Shukla

@Suraj0950 Suraj0950 mentioned this pull request Mar 6, 2025
1 task
@Planeshifter
Copy link
Member

It's not clear which issue this PR attempts to resolve. The diff shows many unwanted changes, which is why I am closing this PR. Feel free to open a new one exclusively containing the requested changes and not messing up various other parts of the README.md or main.c file.

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 6, 2025
@akash8843 akash8843 deleted the fix-missing-section-7141f46 branch March 7, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants