-
-
Notifications
You must be signed in to change notification settings - Fork 906
Fix: Missing section in README and main.c (Issue #7141f46) #5823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Missing section in README and main.c (Issue #7141f46) #5823
Conversation
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hi there! 👋
And thank you for opening your first pull request! We will review it shortly. 🏃 💨
Coverage Report
The above coverage report was generated for the changes in this PR. |
Signed-off-by: Akash shukla <[email protected]>
#### cdf.factory( p ) | ||
|
||
Returns a function for evaluating the [cumulative distribution function][cdf] of a [geometric][geometric-distribution] distribution with success probability `p` | ||
Returns a function for evaluating the [cumulative distribution function][cdf] of a [geometric][geometric-distribution] distribution with success probability `p`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"I added a period at the end to follow proper documentation style. If this change is not required, please let me know — I’ll revert it."
Hello @kgryte, 👋 I hope you are doing well! I have created a pull request to fix the missing section in the README and main.c file for the stdlib-js project: 🔗 PR Link: (akash8843:fix-missing-section-7141f46)] I would really appreciate it if you could review my PR whenever you have some time. Your feedback will help me improve and learn more! Thank you so much for your guidance and support! 🙏 Best regards, |
It's not clear which issue this PR attempts to resolve. The diff shows many unwanted changes, which is why I am closing this PR. Feel free to open a new one exclusively containing the requested changes and not messing up various other parts of the |
Resolves #7141f46
Description
This pull request fixes the missing section in the README file and adds necessary updates to
main.c
.Related Issues
Questions
Other
No.
Checklist
@stdlib-js/reviewers