Skip to content

Conversation

akash8843
Copy link

Resolves #{{Address commit comments (commit 276f077) #5710}}.

Description

This pull request fixes missing opts argument in MGF test cases for the triangular distribution. Added proper test cases to handle edge scenarios and ensure valid function outputs.

Related Issues

Closes #<#5710> (Address commit comments (commit 276f077))

Checklist

  • Added necessary test cases
  • Verified code passes all tests

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 7, 2025
@stdlib-bot
Copy link
Contributor

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

  1. Please read our contributing guidelines.

  2. Update your pull request description to include this checked box:

    - [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

  • The developer's certificate of origin
  • Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

@stdlib-bot stdlib-bot added the Good First PR A pull request resolving a Good First Issue. label Mar 7, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/geometric/cdf $\color{green}291/291$
$\color{green}+100.00\%$
$\color{green}27/27$
$\color{green}+100.00\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{green}291/291$
$\color{green}+100.00\%$
stats/base/dists/triangular/mgf $\color{red}344/348$
$\color{green}+98.85\%$
$\color{red}25/27$
$\color{green}+92.59\%$
$\color{green}4/4$
$\color{green}+100.00\%$
$\color{red}344/348$
$\color{green}+98.85\%$

The above coverage report was generated for the changes in this PR.

@akash8843 akash8843 closed this Mar 7, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 7, 2025
@akash8843 akash8843 deleted the fix/missing-opts-arg branch March 7, 2025 08:44
@akash8843 akash8843 restored the fix/missing-opts-arg branch March 7, 2025 08:44
@akash8843 akash8843 deleted the fix/missing-opts-arg branch March 7, 2025 08:45
@akash8843 akash8843 restored the fix/missing-opts-arg branch March 7, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants