fix: corrected spacing in if condition in geometric quantile implementation #5948

mukulchauuhan · 2025-03-10T08:46:16Z

Resolves #5948

Description

What is the purpose of this pull request?

This pull request:

Fixes spacing issues in the if condition of the geometric quantile implementation.
Improves code readability and aligns with project standards.

Related Issues

Does this pull request have any related issues?

This pull request:

Resolves fix: corrected spacing in if condition in geometric quantile implementation #5948

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No additional notes.

Checklist

Read, understood, and followed the contributing guidelines

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: missing_dependencies - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

stdlib-bot · 2025-03-10T08:46:50Z

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

Please read our contributing guidelines.
Update your pull request description to include this checked box:

- [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

The developer's certificate of origin
Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

stdlib-bot

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

stdlib-bot · 2025-03-10T08:47:51Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/base/dists/geometric/quantile	$\color{green}309/309$ $\color{green}+100.00\%$	$\color{green}27/27$ $\color{green}+100.00\%$	$\color{green}4/4$ $\color{green}+100.00\%$	$\color{green}309/309$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

lib/node_modules/@stdlib/stats/base/dists/geometric/quantile/src/main.c

…rc/main.c Signed-off-by: Gunj Joshi <[email protected]>

gunjjoshi · 2025-03-10T09:30:43Z

Thanks @mukulchauuhan!

kgryte · 2025-03-10T09:41:13Z

@mukulchauuhan Is there an issue that this PR is intended to close?

mukulchauuhan · 2025-03-10T10:05:32Z

@mukulchauuhan Is there an issue that this PR is intended to close?

Yes it was issue #5948

mukulchauuhan · 2025-03-10T10:07:55Z

@kgryte Sir,
If I have made any mistake in my PR, I sincerely request you to kindly guide me. I’m truly eager to learn and improve so that I can become a better contributor. This was my very first PR, and I’m genuinely thankful for the opportunity to contribute. 🙏

mukulchauuhan · 2025-03-10T10:41:15Z

Thanks for the clarification! I’ve added Closes #5948 in the PR description to link the issue properly. Let me know if there’s anything I should improve.

Planeshifter · 2025-03-11T01:57:21Z

@mukulchauuhan #5948 is this PR, so that cannot be the issue this PR is resolving.

anxhukumar · 2025-03-11T16:59:28Z

@mukulchauuhan You have inserted your own template for the initial PR comment, you can still edit the comment and use the native template for pr requests. The default template gives a lot of clarity.

Refer the introductory markdown files before you proceed.

mukulchauuhan · 2025-03-12T03:25:08Z

@mukulchauuhan You have inserted your own template for the initial PR comment, you can still edit the comment and use the native template for pr requests. The default template gives a lot of clarity.

Refer the introductory markdown files before you proceed.

Thank you for the valuable feedback, @anxhukumar
I’ll make the necessary changes and update the PR using the standard template as suggested.
I’ll also go through the introductory markdown files to ensure everything aligns well with the project guidelines.

stdlib-bot · 2025-03-12T03:30:02Z

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

Please read our contributing guidelines.
Update your pull request description to include this checked box:

- [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

The developer's certificate of origin
Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

stdlib-bot · 2025-03-12T03:32:17Z

Hello! Thank you for your contribution to stdlib.

We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:

Please read our contributing guidelines.
Update your pull request description to include this checked box:

- [x] Read, understood, and followed the [contributing guidelines](https://github.com/stdlib-js/stdlib/blob/develop/CONTRIBUTING.md)

This acknowledgment confirms that you've read the guidelines, which include:

The developer's certificate of origin
Your agreement to license your contributions under the project's terms

We can't review or accept contributions without this acknowledgment.

Thank you for your understanding and cooperation. We look forward to reviewing your contribution!

anxhukumar · 2025-03-12T03:36:20Z

@mukulchauuhan #5948 is not the issue you are solving, that represents your pr. Use a correct issue tag.

mukulchauuhan · 2025-03-12T09:58:56Z

Hi @anxhukumar, I wanted to double-check something. I believe this pull request is intended to address issue #5948 (the geometric quantile implementation spacing issue). Could you help me understand what you're seeing that suggests a different issue? I'm still learning the process, so any guidance is appreciated!

When I'm writing Resolves 5948, I think this means this is connected to the issue number and not the pull request number. If this is the case then I am putting the right thing on the top, i.e. resolves 5948 which is indeed the issue number for the related issue fix: corrected spacing in if condition in geometric quantile implementation #5948

I didn't clearly get this thing that you said about - Use a correct issue tag ! Please can you provide me more information regarding my mistake (if I am making any) :)

kgryte · 2025-03-17T06:56:55Z

@mukulchauuhan In order for this PR to move forward, we need to know the issue number that this PR is intended to resolve. Please find the issue number from the following list of issues: https://github.com/stdlib-js/stdlib/issues?q=sort%3Aupdated-desc+is%3Aissue+is%3Aopen

mukulchauuhan · 2025-03-17T09:00:35Z

@kgryte, Hello Sir, I had been searching this issue for more than an hour, I think I am loosing something. Either I am unable to see the issue there or it is not present. But I remember it was present and had a good first issue tag on it. Please help me out sir.

kgryte · 2025-03-17T09:06:41Z

The issue was #5896. That issue was already resolved in #5972. As such, I'll go ahead and close this PR.

stdlib-bot added Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 10, 2025

stdlib-bot reviewed Mar 10, 2025

View reviewed changes

gunjjoshi reviewed Mar 10, 2025

View reviewed changes

lib/node_modules/@stdlib/stats/base/dists/geometric/quantile/src/main.c Outdated Show resolved Hide resolved

Update lib/node_modules/@stdlib/stats/base/dists/geometric/quantile/s…

4f0c303

…rc/main.c Signed-off-by: Gunj Joshi <[email protected]>

gunjjoshi approved these changes Mar 10, 2025

View reviewed changes

kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 17, 2025

kgryte closed this Mar 17, 2025

kgryte added Duplicate This issue or pull request already exists. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 17, 2025

Uh oh!

fix: corrected spacing in if condition in geometric quantile implementation #5948

fix: corrected spacing in if condition in geometric quantile implementation #5948

Uh oh!

Conversation

mukulchauuhan commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Mar 10, 2025

Uh oh!

stdlib-bot left a comment

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Uh oh!

gunjjoshi commented Mar 10, 2025

Uh oh!

kgryte commented Mar 10, 2025

Uh oh!

mukulchauuhan commented Mar 10, 2025

Uh oh!

mukulchauuhan commented Mar 10, 2025

Uh oh!

mukulchauuhan commented Mar 10, 2025

Uh oh!

Planeshifter commented Mar 11, 2025

Uh oh!

anxhukumar commented Mar 11, 2025

Uh oh!

mukulchauuhan commented Mar 12, 2025

Uh oh!

stdlib-bot commented Mar 12, 2025

Uh oh!

stdlib-bot commented Mar 12, 2025

Uh oh!

anxhukumar commented Mar 12, 2025

Uh oh!

mukulchauuhan commented Mar 12, 2025

Uh oh!

kgryte commented Mar 17, 2025

Uh oh!

mukulchauuhan commented Mar 17, 2025

Uh oh!

kgryte commented Mar 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mukulchauuhan commented Mar 10, 2025 •

edited

Loading

stdlib-bot commented Mar 10, 2025 •

edited

Loading