Skip to content

Conversation

Shivam-1827
Copy link
Contributor

@Shivam-1827 Shivam-1827 commented Mar 13, 2025

Resolves #6005

Description

What is the purpose of this pull request?

This pull request:

  • Fixes a C linting issue in lib/node_modules/@stdlib/math/base/special/roundn/src/addon.c .
  • Resolves a style issue where the local variable stdlib_base_roundn was incorrectly formatted or defined, leading to linting failures in the automated workflow.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

The linting failure was detected in the automated C Linting workflow run on 2025-03-13.
Workflow details:

The specific error was:

image

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Mar 13, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 13, 2025

Coverage Report

Package Statements Branches Functions Lines
math/base/special/roundn $\color{red}276/279$
$\color{green}+98.92\%$
$\color{green}22/22$
$\color{green}+100.00\%$
$\color{red}1/2$
$\color{green}+50.00\%$
$\color{red}276/279$
$\color{green}+98.92\%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Member

kgryte commented Mar 19, 2025

Hello, and thank you for your contribution; however, your proposed changes do not actually address the lint error. The lint error was addressed in #6194. As such, I'll go ahead and close.

cc @Planeshifter

@kgryte kgryte added Duplicate This issue or pull request already exists. and removed Needs Review A pull request which needs code review. labels Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Duplicate This issue or pull request already exists. Math Issue or pull request specific to math functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix C lint errors

4 participants