Skip to content

Conversation

hemantmm
Copy link
Contributor

Resolves #4977

Description

What is the purpose of this pull request?

This pull request:

  • Refactor random number generation in JS benchmarks for stats/base/dists/levy

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 14, 2025
Signed-off-by: hemantmm <[email protected]>
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 14, 2025

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/levy/cdf $\color{green}234/234$
$\color{green}+100.00\%$
$\color{green}21/21$
$\color{green}+100.00\%$
$\color{green}3/3$
$\color{green}+100.00\%$
$\color{green}234/234$
$\color{green}+100.00\%$
stats/base/dists/levy/ctor $\color{green}420/420$
$\color{green}+100.00\%$
$\color{green}32/32$
$\color{green}+100.00\%$
$\color{green}16/16$
$\color{green}+100.00\%$
$\color{green}420/420$
$\color{green}+100.00\%$
stats/base/dists/levy/entropy $\color{green}120/120$
$\color{green}+100.00\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}120/120$
$\color{green}+100.00\%$
stats/base/dists/levy/logcdf $\color{green}238/238$
$\color{green}+100.00\%$
$\color{green}21/21$
$\color{green}+100.00\%$
$\color{green}3/3$
$\color{green}+100.00\%$
$\color{green}238/238$
$\color{green}+100.00\%$
stats/base/dists/levy/logpdf $\color{green}222/222$
$\color{green}+100.00\%$
$\color{green}21/21$
$\color{green}+100.00\%$
$\color{green}3/3$
$\color{green}+100.00\%$
$\color{green}222/222$
$\color{green}+100.00\%$
stats/base/dists/levy/mean $\color{green}176/176$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}176/176$
$\color{green}+100.00\%$
stats/base/dists/levy/mode $\color{green}175/175$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}175/175$
$\color{green}+100.00\%$
stats/base/dists/levy/pdf $\color{green}216/216$
$\color{green}+100.00\%$
$\color{green}21/21$
$\color{green}+100.00\%$
$\color{green}3/3$
$\color{green}+100.00\%$
$\color{green}216/216$
$\color{green}+100.00\%$
stats/base/dists/levy/stdev $\color{green}176/176$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}176/176$
$\color{green}+100.00\%$
stats/base/dists/levy/variance $\color{green}176/176$
$\color{green}+100.00\%$
$\color{green}9/9$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}176/176$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Signed-off-by: hemantmm <[email protected]>
@hemantmm
Copy link
Contributor Author

@anandkaranubc have a look at the PR.

@Planeshifter Planeshifter added the Potential Duplicate There might be another pull request resolving the same issue. label Mar 15, 2025
@hemantmm
Copy link
Contributor Author

@anandkaranubc any update?

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after clean-up.

@kgryte kgryte added Benchmarks Pull requests adding or improving benchmarks for measuring performance. and removed Needs Review A pull request which needs code review. Potential Duplicate There might be another pull request resolving the same issue. labels Mar 22, 2025
@kgryte kgryte merged commit 73050cb into stdlib-js:develop Mar 22, 2025
29 checks passed
Girish-Garg pushed a commit to Girish-Garg/stdlib that referenced this pull request Mar 23, 2025
PR-URL: stdlib-js#6044
Closes: stdlib-js#4977
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: hemantmm <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
sahil20021008 pushed a commit to sahil20021008/stdlib that referenced this pull request Mar 26, 2025
PR-URL: stdlib-js#6044
Closes: stdlib-js#4977
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Signed-off-by: hemantmm <[email protected]>
Signed-off-by: Athan Reines <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Benchmarks Pull requests adding or improving benchmarks for measuring performance. Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Refactor random number generation in JS benchmarks for stats/base/dists/levy

4 participants