-
-
Notifications
You must be signed in to change notification settings - Fork 906
feat: add constants/float32/max-safe-nth-tribonacci
#6049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
@kgryte @Planeshifter LMK your views on this |
lib/node_modules/@stdlib/constants/float32/max-safe-nth-tribonacci/lib/index.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/constants/float32/max-safe-nth-tribonacci/package.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry. I take this back. @Neerajpathak07 how did you calculate the maximum safe tribonacci? When checking in the REPL, I find
In [40]: base.tribonacci(30)
Out[40]: 15902591
In [41]: FLOAT32_MAX_SAFE_INTEGER
Out[41]: 16777215
In [42]: base.tribonacci(31)
Out[42]: 29249425
base.tribonacci( 35 )
far exceeds the maximum safe float32.
@kgryte Was using a external Float Converter which would be the reason for the inaccurate values. Was having doubts on how to use the |
Resolves #6050.
Description
This pull request:
constants/float32/max-safe-nth-tribonacci
to expand the scope for float32 operations.Related Issues
This pull request:
constants/float32/max-safe-nth-tribonacci
#6050Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers