Skip to content

Conversation

NishchayRajput
Copy link
Contributor

@NishchayRajput NishchayRajput commented Mar 16, 2025

Ref: #649

Description

What is the purpose of this pull request?

This pull request:

  • Add implementation of math/base/special/binomcoeff

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@NishchayRajput NishchayRajput marked this pull request as draft March 16, 2025 12:15
@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Mar 16, 2025
@Planeshifter
Copy link
Member

⚠️ Tracking Issue Closure Warning ⚠️

I noticed your PR description contains closing keywords ("Resolves", "Closes", or "Fixes") referencing a "Tracking Issue".

Why this matters:
Tracking issues should typically remain open until all related sub-issues are completed. GitHub automatically closes issues with such closing keywords when the PR is merged.

Required action:
Use "Progresses:" or "Ref:" instead to reference the tracking issue without automatically closing it.

Thank you for your contribution to the project!

dir = dirname( file );

# Integer values:
n = round.( Int, ( rand( 1000 ) .* 50 ) .+ 20 );
Copy link
Contributor

@anandkaranubc anandkaranubc Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Referring to the conversation on Gitter, this is what you can use:

Suggested change
n = round.( Int, ( rand( 1000 ) .* 50 ) .+ 20 );
n = round.( Int, ( rand( 1000 ) .* 5 ) .+ 20 );

Similarly, this applies to negative n values as well.

@anandkaranubc
Copy link
Contributor

Completed via #7000

@anandkaranubc anandkaranubc added the autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. label May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autoclose: Already Resolved Pull request which should be auto-closed due proposed changes duplicating already included changes. Math Issue or pull request specific to math functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants