docs: add FAQ for linting errors #6157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: na
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
- task: run_javascript_examples
status: na
- task: run_c_examples
status: na
- task: run_cpp_examples
status: na
- task: run_javascript_readme_examples
status: na
- task: run_c_benchmarks
status: na
- task: run_cpp_benchmarks
status: na
- task: run_fortran_benchmarks
status: na
- task: run_javascript_benchmarks
status: na
- task: run_julia_benchmarks
status: na
- task: run_python_benchmarks
status: na
- task: run_r_benchmarks
status: na
- task: run_javascript_tests
status: na
---
|
@aayush0325, please check this FAQ. Also I think we should have a FAQ for max length in javascript files too. What is your opinion? |
kgryte
added
the
Documentation
Signed-off-by: Shabareesh Shetty <[email protected]>
|
@aayush0325, I have added reference links as well as a FAQ for max length of javascript. Also I have removed a TODO in line 68 because I thought it was outdated. Please check if I am right. |
anandkaranubc
requested changes
Mar 19, 2025
Signed-off-by: Shabareesh Shetty <[email protected]>
Signed-off-by: Shabareesh Shetty <[email protected]>
1 task
Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Shabareesh Shetty <[email protected]>
Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Shabareesh Shetty <[email protected]>
Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Shabareesh Shetty <[email protected]>
Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Shabareesh Shetty <[email protected]>
Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Shabareesh Shetty <[email protected]>
Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Shabareesh Shetty <[email protected]>
ShabiShett07
changed the title
I have changed the title |
anandkaranubc
requested changes
Mar 21, 2025
anandkaranubc
added
Needs Changes
Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Shabareesh Shetty <[email protected]>
Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Shabareesh Shetty <[email protected]>
Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Shabareesh Shetty <[email protected]>
Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Shabareesh Shetty <[email protected]>
|
@anandkaranubc, I think I have solved all your comments, sorry for not noticing the comments |
Signed-off-by: Karan Anand <[email protected]>
anandkaranubc
approved these changes
Mar 21, 2025
Planeshifter
approved these changes
Mar 24, 2025
Planeshifter
added
the
Ready To Merge
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
stdlib-bot
removed
the
Needs Changes
sahil20021008
pushed a commit
to sahil20021008/stdlib
that referenced
this pull request
Mar 26, 2025
PR-URL: stdlib-js#6157 Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Karan Anand <[email protected]> Signed-off-by: Shabareesh Shetty <[email protected]> Reviewed-by: Karan Anand <[email protected]> Reviewed-by: Philipp Burckhardt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
type: pre_push_report
description: Results of running various checks prior to pushing changes. report:
none
Description
This pull request:
Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers