feat: add `math/base/special/lucasf` #6223

hrshya · 2025-03-20T09:03:29Z

Resolves none .

Description

What is the purpose of this pull request?

This pull request:

adds math/base/special/lucasf .

Related Issues

Does this pull request have any related issues?

This pull request:

progresses [RFC]: Add C implementations to base special math functions (tracking issue) #649 .

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

stdlib-bot · 2025-03-20T11:23:39Z

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/lucasf	$\color{green}224/224$ $\color{green}+100.00\%$	$\color{green}10/10$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}224/224$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Signed-off-by: Harsh <[email protected]>

hrshya · 2025-03-22T18:13:53Z

@anandkaranubc could you please review this PR?

Signed-off-by: Harsh <[email protected]>

kgryte · 2025-04-02T09:14:27Z

@anandkaranubc Would you mind taking a look at this PR?

anandkaranubc · 2025-04-05T02:18:13Z

/stdlib merge

anandkaranubc

Hi @hrshya, thanks for your work on this! I’ve added some comments on the PR. A few areas need improvement.

lib/node_modules/@stdlib/math/base/special/lucasf/src/addon.c

lib/node_modules/@stdlib/math/base/special/lucasf/src/main.c

lib/node_modules/@stdlib/math/base/special/lucasf/examples/c/example.c

lib/node_modules/@stdlib/math/base/special/lucasf/lib/main.js

lib/node_modules/@stdlib/math/base/special/lucasf/lib/index.js

anandkaranubc · 2025-04-05T02:51:26Z

lib/node_modules/@stdlib/math/base/special/lucasf/README.md

+
+#### lucasf( n )
+
+Computes the nth [Lucas number][lucas-number] in single-precision floating-point format.


Same comment

anandkaranubc · 2025-04-05T02:52:18Z

lib/node_modules/@stdlib/math/base/special/lucasf/README.md

+<!-- eslint no-undef: "error" -->
+
+```javascript
+var lucasf = require( '@stdlib/math/base/special/lucasf' );


This should also be refactored to use logEachMap

Shouldn't we use array/base/linspace here to get the lucasf values in an increasing order like lucasf( 0 ) till n as compared to using a discreteUniform here which would give us random lucasf values.

cc: @anandkaranubc

@hrshya Either is fine, I believe. The goal is to showcase a working code example. I changed it to use discreteUniform to align with the other refactoring being done in math/base/special. Another reason is that you were using linspace with four arguments, including opts, which linspace doesn't require.

stdlib/lib/node_modules/@stdlib/array/base/linspace/lib/main.js

Line 35 in 1871022

function linspace( x1, x2, len ) {

If you think this change was accidentally propagated to other packages, a PR is probably needed for that.

anandkaranubc · 2025-04-05T02:52:29Z

lib/node_modules/@stdlib/math/base/special/lucasf/README.md

+
+#### stdlib_base_lucasf( n )
+
+Computes the nth [Lucas number][lucas-number] in single-precision floating-point format.


Same comment

lib/node_modules/@stdlib/math/base/special/lucasf/README.md

Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Harsh <[email protected]>

…xample.c Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Harsh <[email protected]>

Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Harsh <[email protected]>

stdlib-bot · 2025-04-06T15:24:06Z

/stdlib lint-autofix

@anandkaranubc, the slash command failed to complete. Please check the workflow logs for details.

View workflow run

anandkaranubc · 2025-04-06T15:33:03Z

lib/node_modules/@stdlib/math/base/special/lucasf/benchmark/benchmark.js

+
+		// TODO: replace with `powf` when available
+		return roundf( pow( PHI, n ) );
+	}


@hrshya, this needs to be fixed. There is a missing function implementation. This is the primary reason why the CI/CD workflows are failing. It's a good practice to run the benchmarks locally first to confirm if nothing is broken.

I did ran the benchmarks when I first created the PR but not this time because there were any major changes in those files.

anandkaranubc · 2025-04-06T15:34:57Z

As a side note, always make sure your feature branch is in sync with the develop branch. This was the reason why there were many unrelated file changes in your previous commits.

Discussion

hrshya · 2025-04-06T16:45:53Z

As a side note, always make sure your feature branch is in sync with the develop branch. This was the reason why there were many unrelated file changes in your previous commits.

Discussion

Actually it was in sync but the thing was I didn't have this branch locally so I pulled it from origin and i thought as my develop branch is in sync so this branch would also be but i was wrong and i should have checked it before commiting

Signed-off-by: Harsh <[email protected]>

hrshya · 2025-04-06T17:59:14Z

@anandkaranubc All the issues have been resolved. Can you give it a quick review.

anandkaranubc · 2025-04-16T01:48:29Z

/stdlib merge

stdlib-bot · 2025-04-16T01:50:35Z

/stdlib merge

@anandkaranubc, the slash command failed to complete. Please check the workflow logs for details.

View workflow run

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: passed - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

anandkaranubc

Good to go! Thanks @hrshya.

feat: add math/base/special/lucasf

361a388

stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Mar 20, 2025

hrshya marked this pull request as draft March 20, 2025 09:09

stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 20, 2025

hrshya added 2 commits March 20, 2025 16:23

fix: fixes ci issues

cf606d1

fix: fixes ci issues

86c575b

hrshya marked this pull request as ready for review March 20, 2025 11:40

stdlib-bot added the Needs Review A pull request which needs code review. label Mar 20, 2025

resolve lint errors

bda525f

Signed-off-by: Harsh <[email protected]>

anandkaranubc self-requested a review March 22, 2025 19:24

update README.md

d748e4e

Signed-off-by: Harsh <[email protected]>

anandkaranubc changed the title ~~feat: add math/base/special/lucasf~~ feat: add math/base/special/lucasf Mar 23, 2025

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 5, 2025

Merge remote-tracking branch 'upstream/develop' into feat/lucasf

3e0abaf

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 5, 2025

anandkaranubc requested changes Apr 5, 2025

View reviewed changes

anandkaranubc added JavaScript Issue involves or relates to JavaScript. C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Apr 5, 2025

hrshya and others added 5 commits April 5, 2025 16:44

Update lib/node_modules/@stdlib/math/base/special/lucasf/src/addon.c

2e66f7e

Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Harsh <[email protected]>

Update lib/node_modules/@stdlib/math/base/special/lucasf/src/main.c

5eb3aea

Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Harsh <[email protected]>

Update lib/node_modules/@stdlib/math/base/special/lucasf/examples/c/e…

3de4e3c

…xample.c Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Harsh <[email protected]>

Update lib/node_modules/@stdlib/math/base/special/lucasf/lib/main.js

f99b17c

Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Harsh <[email protected]>

Update lib/node_modules/@stdlib/math/base/special/lucasf/lib/index.js

01cac68

Co-authored-by: Karan Anand <[email protected]> Signed-off-by: Harsh <[email protected]>

stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 6, 2025

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 6, 2025

anandkaranubc reviewed Apr 6, 2025

View reviewed changes

hrshya added 3 commits April 6, 2025 22:31

adds function implementation

932d113

Signed-off-by: Harsh <[email protected]>

update benchmark.js

7b1c4e0

Signed-off-by: Harsh <[email protected]>

resolve lint issue

eee36a8

Signed-off-by: Harsh <[email protected]>

anandkaranubc self-requested a review April 16, 2025 01:48

stdlib-bot added Needs Review A pull request which needs code review. bot: In Progress Pull request is currently awaiting automation. labels Apr 16, 2025

stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 16, 2025

anandkaranubc added 7 commits April 17, 2025 01:21

anandkaranubc approved these changes Apr 17, 2025

View reviewed changes

anandkaranubc removed the Needs Changes Pull request which needs changes before being merged. label Apr 17, 2025

Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Apr 17, 2025

stdlib-bot removed the Needs Review A pull request which needs code review. label Apr 17, 2025

Planeshifter merged commit 3656652 into stdlib-js:develop Apr 17, 2025
30 of 31 checks passed

anandkaranubc mentioned this pull request Apr 17, 2025

feat: add math/base/special/lucasf #3348

Closed

1 task

hrshya deleted the feat/lucasf branch October 11, 2025 13:37


		#### lucasf( n )

		Computes the nth [Lucas number][lucas-number] in single-precision floating-point format.


		#### stdlib_base_lucasf( n )

		Computes the nth [Lucas number][lucas-number] in single-precision floating-point format.

Uh oh!

feat: add math/base/special/lucasf #6223

feat: add math/base/special/lucasf #6223

Uh oh!

Conversation

hrshya commented Mar 20, 2025

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

hrshya commented Mar 22, 2025

Uh oh!

kgryte commented Apr 2, 2025

Uh oh!

anandkaranubc commented Apr 5, 2025

Uh oh!

anandkaranubc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

anandkaranubc Apr 5, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Apr 5, 2025

Choose a reason for hiding this comment

Uh oh!

hrshya Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Apr 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

stdlib-bot commented Apr 6, 2025

Uh oh!

anandkaranubc Apr 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hrshya Apr 6, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc commented Apr 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hrshya commented Apr 6, 2025

Uh oh!

hrshya commented Apr 6, 2025

Uh oh!

anandkaranubc commented Apr 16, 2025

Uh oh!

stdlib-bot commented Apr 16, 2025

Uh oh!

anandkaranubc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

feat: add `math/base/special/lucasf` #6223

feat: add `math/base/special/lucasf` #6223

stdlib-bot commented Mar 20, 2025 •

edited

Loading

anandkaranubc Apr 6, 2025 •

edited

Loading

anandkaranubc commented Apr 6, 2025 •

edited

Loading