Skip to content

Conversation

23f3001304
Copy link
Contributor

Resolves #5609 .

Description

What is the purpose of this pull request?

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Modified test cases are passing.

image

Examples with NaN generated successfully

image

All 9 benchmarks are passed

image

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Good First PR A pull request resolving a Good First Issue. Statistics Issue or pull request related to statistical functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review. labels Mar 22, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 22, 2025

Coverage Report

Package Statements Branches Functions Lines
stats/incr/nanmstdev $\color{green}230/230$
$\color{green}+100.00\%$
$\color{green}11/11$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}230/230$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte changed the title feat: added wrapper to moving corrected sample standard deviation incrementally computing function for ignoring NaN values. feat: add stats/incr/nanmstdev Apr 16, 2025
@Planeshifter Planeshifter self-requested a review April 16, 2025 00:11
@Planeshifter
Copy link
Member

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Apr 16, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Apr 16, 2025
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions, @coehemang!

Left a few comments; mainly I believe that the example code in the README.md files in all of your PRs deso not match the implementations. Please double-check.

There are also lint errors, so please make sure you have your development environment setup correctly.

@23f3001304 23f3001304 requested a review from Planeshifter April 25, 2025 06:00
@23f3001304
Copy link
Contributor Author

@Planeshifter I think, I have fixed the issues you have mentioned (mainly the linting issues) will be waiting for another review for the same

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @coehemang, for the PR and updates! Will merge once CI checks are green.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label May 3, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label May 3, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add `stats/incr/nanmstdev`

PR-URL: https://github.com/stdlib-js/stdlib/pull/6297
Closes: https://github.com/stdlib-js/stdlib/issues/5609

Co-authored-by: Hemang Chodhary <[email protected]>
Co-authored-by: Philipp Burckhardt <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 9bec44a into stdlib-js:develop May 3, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Ready To Merge A pull request which is ready to be merged. Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: add stats/incr/nanmstdev

3 participants