Skip to content

Conversation

hrshya
Copy link
Contributor

@hrshya hrshya commented Mar 24, 2025

Resolves none .

Description

What is the purpose of this pull request?

This pull request:

  • Refactors random number generation in JS benchmarks for the math/base/special/lcm, math/base/special/kernel-betainc, math/base/special/kernel-betaincinv and math/base/special/gammasgn packages.
  • Replaces randu() with uniform() from @stdlib/random/array/uniform for cleaner and more consistent code.
  • Moves the random number generation outside the benchmarking loops.
  • Updates the test messages to follow code conventions.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves no related issues.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Mar 24, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/special/gammasgn $\color{green}175/175$
$\color{green}+100.00\%$
$\color{green}13/13$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}175/175$
$\color{green}+100.00\%$
math/base/special/kernel-betainc $\color{red}931/1730$
$\color{green}+53.82\%$
$\color{red}29/39$
$\color{green}+74.36\%$
$\color{red}2/13$
$\color{green}+15.38\%$
$\color{red}931/1730$
$\color{green}+53.82\%$
math/base/special/kernel-betaincinv $\color{red}2552/3171$
$\color{green}+80.48\%$
$\color{red}114/168$
$\color{green}+67.86\%$
$\color{red}23/37$
$\color{green}+62.16\%$
$\color{red}2552/3171$
$\color{green}+80.48\%$
math/base/special/lcm $\color{green}165/165$
$\color{green}+100.00\%$
$\color{green}14/14$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}165/165$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter changed the title bench: update random value generation chore: update random value generation and test descriptions Mar 25, 2025
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 25, 2025
@Planeshifter Planeshifter changed the title chore: update random value generation and test descriptions chore: update random value generation and test messages Mar 25, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

chore: update random value generation and test messages

PR-URL: https://github.com/stdlib-js/stdlib/pull/6346

Co-authored-by: hrshya <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 25, 2025
@Planeshifter Planeshifter merged commit 90d0d11 into stdlib-js:develop Mar 25, 2025
74 checks passed
sahil20021008 pushed a commit to sahil20021008/stdlib that referenced this pull request Mar 26, 2025
@hrshya hrshya deleted the fix/klcm branch April 10, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants