Skip to content

Conversation

hrshya
Copy link
Contributor

@hrshya hrshya commented Mar 24, 2025

Resolves none .

Description

What is the purpose of this pull request?

This pull request:

  • replaces manual for loop in examples for math/base/special/ellipe, math/base/special/ellipk, math/base/special/erf, math/base/special/erfc, math/base/special/erfcinv, math/base/special/erfcx and math/base/special/erfinv packages.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves no related issues.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Mar 24, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 24, 2025

Coverage Report

Package Statements Branches Functions Lines
math/base/special/ellipe $\color{red}833/857$
$\color{green}+97.20\%$
$\color{red}59/71$
$\color{green}+83.10\%$
$\color{green}14/14$
$\color{green}+100.00\%$
$\color{red}833/857$
$\color{green}+97.20\%$
math/base/special/ellipk $\color{red}845/869$
$\color{green}+97.24\%$
$\color{red}59/71$
$\color{green}+83.10\%$
$\color{green}14/14$
$\color{green}+100.00\%$
$\color{red}845/869$
$\color{green}+97.24\%$
math/base/special/erf $\color{red}870/882$
$\color{green}+98.64\%$
$\color{red}52/58$
$\color{green}+89.66\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{red}870/882$
$\color{green}+98.64\%$
math/base/special/erfc $\color{red}895/907$
$\color{green}+98.68\%$
$\color{red}55/61$
$\color{green}+90.16\%$
$\color{green}10/10$
$\color{green}+100.00\%$
$\color{red}895/907$
$\color{green}+98.68\%$
math/base/special/erfcinv $\color{red}630/659$
$\color{green}+95.60\%$
$\color{red}43/56$
$\color{green}+76.79\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{red}630/659$
$\color{green}+95.60\%$
math/base/special/erfcx $\color{red}1368/1443$
$\color{green}+94.80\%$
$\color{green}95/95$
$\color{green}+100.00\%$
$\color{red}79/104$
$\color{green}+75.96\%$
$\color{red}1368/1443$
$\color{green}+94.80\%$
math/base/special/erfinv $\color{red}648/677$
$\color{green}+95.72\%$
$\color{red}43/56$
$\color{green}+76.79\%$
$\color{green}7/7$
$\color{green}+100.00\%$
$\color{red}648/677$
$\color{green}+95.72\%$

The above coverage report was generated for the changes in this PR.

Signed-off-by: Harsh <[email protected]>
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 25, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 25, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

docs: replace manual `for` loop in examples

PR-URL: https://github.com/stdlib-js/stdlib/pull/6351

Co-authored-by: Harsh <[email protected]>
Co-authored-by: hrshya <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Harsh <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 2e1dd43 into stdlib-js:develop Mar 25, 2025
29 checks passed
sahil20021008 pushed a commit to sahil20021008/stdlib that referenced this pull request Mar 26, 2025
PR-URL: stdlib-js#6351

Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Harsh <[email protected]>
@hrshya hrshya deleted the docs/erf branch April 10, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants