Skip to content

Conversation

anandkaranubc
Copy link
Contributor

Resolves None

Description

What is the purpose of this pull request?

This pull request:

  • Adds the complete implementation of constants/float32/max-safe-nth-double-factorial

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Mar 25, 2025
@anandkaranubc
Copy link
Contributor Author

In [27]: base.factorial2(57) <= FLOAT32_MAX
Out[27]: false

In [28]: base.factorial2(56) <= FLOAT32_MAX
Out[28]: true

Tested 😄

@anandkaranubc
Copy link
Contributor Author

This constant is needed for the implementation of math/base/special/factorial2f

@stdlib-bot
Copy link
Contributor

stdlib-bot commented Mar 25, 2025

Coverage Report

Package Statements Branches Functions Lines
constants/float32/max-safe-nth-double-factorial $\color{green}49/49$
$\color{green}+100.00\%$
$\color{green}1/1$
$\color{green}+100.00\%$
$\color{green}0/0$
$\color{green}+100.00\%$
$\color{green}49/49$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@anandkaranubc
Copy link
Contributor Author

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Mar 25, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Mar 25, 2025
@anandkaranubc anandkaranubc added the Potential Duplicate There might be another pull request resolving the same issue. label Mar 26, 2025
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Mar 29, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

feat: add `constants/float32/max-safe-nth-double-factorial`

PR-URL: https://github.com/stdlib-js/stdlib/pull/6364

Co-authored-by: Karan Anand <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Mar 29, 2025
@Planeshifter Planeshifter merged commit c7d839f into stdlib-js:develop Mar 29, 2025
47 checks passed
@anandkaranubc anandkaranubc deleted the constants/f2f branch May 10, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Potential Duplicate There might be another pull request resolving the same issue. Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants