Skip to content

chore: replace separate sin and cos calls with sincos #6365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025
Merged

chore: replace separate sin and cos calls with sincos #6365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions lib/node_modules/@stdlib/math/base/special/ccis/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@
"@stdlib/complex/float64/ctor",
"@stdlib/complex/float64/reim",
"@stdlib/math/base/special/exp",
"@stdlib/math/base/special/cos",
"@stdlib/math/base/special/sin"
"@stdlib/math/base/special/sincos"
]
},
{
Expand All @@ -58,8 +57,7 @@
"@stdlib/complex/float64/ctor",
"@stdlib/complex/float64/reim",
"@stdlib/math/base/special/exp",
"@stdlib/math/base/special/cos",
"@stdlib/math/base/special/sin"
"@stdlib/math/base/special/sincos"
]
},
{
Expand All @@ -76,8 +74,7 @@
"@stdlib/complex/float64/ctor",
"@stdlib/complex/float64/reim",
"@stdlib/math/base/special/exp",
"@stdlib/math/base/special/cos",
"@stdlib/math/base/special/sin"
"@stdlib/math/base/special/sincos"
]
}
]
Expand Down
7 changes: 2 additions & 5 deletions lib/node_modules/@stdlib/math/base/special/ccis/src/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@
#include "stdlib/complex/float64/ctor.h"
#include "stdlib/complex/float64/reim.h"
#include "stdlib/math/base/special/exp.h"
#include "stdlib/math/base/special/sin.h"
#include "stdlib/math/base/special/cos.h"
#include "stdlib/math/base/special/sincos.h"

/**
* Evaluates the cis function for a double-precision complex floating-point number.
Expand Down Expand Up @@ -68,9 +67,7 @@ stdlib_complex128_t stdlib_base_ccis( const stdlib_complex128_t z ) {

stdlib_complex128_reim( z, &re, &im );

// TODO: replace with stdlib/math/base/special/sincos
y = stdlib_base_sin( re );
x = stdlib_base_cos( re );
stdlib_base_sincos( re, &y, &x );
if( im != 0.0 ) {
e = stdlib_base_exp( -im );
y *= e;
Expand Down