Skip to content

Conversation

devshree-bhati
Copy link
Contributor

@devshree-bhati devshree-bhati commented Apr 21, 2025

Resolves #6715

Description

This PR addresses the commit comments for commit 4d0f11a from core contributors. The 'float64ToUint32' wrapper was no longer needed so I removed the import statement.

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Needs Review A pull request which needs code review. labels Apr 21, 2025
@stdlib-bot
Copy link
Contributor

Coverage Report

Package Statements Branches Functions Lines
math/base/assert/uint32-is-pow2 $\color{green}143/143$
$\color{green}+100.00\%$
$\color{green}6/6$
$\color{green}+100.00\%$
$\color{green}2/2$
$\color{green}+100.00\%$
$\color{green}143/143$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @devshree-bhati!

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Apr 22, 2025
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Apr 22, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

chore: address commit comments for commit `4d0f11a` (issue #6715)

PR-URL: https://github.com/stdlib-js/stdlib/pull/6770
Closes: https://github.com/stdlib-js/stdlib/issues/6715

Co-authored-by: Devshree <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 4dcbec5 into stdlib-js:develop Apr 22, 2025
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Good First PR A pull request resolving a Good First Issue. Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Address commit comments (commit 4d0f11a)

3 participants