chore: fix EditorConfig lint errors (issue #6925) #6929
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lalit Narayan Yadav <[email protected]>
Signed-off-by: Lalit Narayan Yadav <[email protected]>
stdlib-bot
added
Good First PR
Signed-off-by: Lalit Narayan Yadav <[email protected]>
Signed-off-by: Lalit Narayan Yadav <[email protected]>
Signed-off-by: Lalit Narayan Yadav <[email protected]>
Signed-off-by: Lalit Narayan Yadav <[email protected]>
ShabiShett07
reviewed
May 5, 2025
lib/node_modules/@stdlib/assert/napi/is-typedarray/manifest.json
Outdated
Show resolved
Hide resolved
ShabiShett07
reviewed
May 5, 2025
| - name: 'Install dependencies' | ||
| if: steps.cache.outputs.cache-hit != 'true' | ||
| run: | | ||
| make install-node-modules || make install-node-modules || make install-node-modules |
There was a problem hiding this comment.
Also I am not sure, is this included by mistake in this PR?
Co-authored-by: Shabareesh Shetty <[email protected]> Signed-off-by: Lalit Narayan Yadav <[email protected]>
|
@LalitNarayanYadav, still the manifest.json indentation is not proper, please refer other packages for proper indentation |
Signed-off-by: Lalit Narayan Yadav <[email protected]>
Signed-off-by: Lalit Narayan Yadav <[email protected]>
Signed-off-by: Lalit Narayan Yadav <[email protected]>
Planeshifter
requested changes
May 5, 2025
There was a problem hiding this comment.
As mentioned by @ShabiShett07, this PR contains extraneous changes in .github/workflows/run_tests_coverage.yml that shouldn't be part of this PR.
Signed-off-by: Lalit Narayan Yadav <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6925
Description
update indentation style in scaffold.sh and is-typedarray manifest
lib/node_modules/@stdlib/_tools/scaffold/math-strided-binary-by/scripts/scaffold.sh(lines 71–78).lib/node_modules/@stdlib/assert/napi/is-typedarray/manifest.json(lines 2–27) to align with project formatting conventions.Related Issues
#6925
Checklist
@stdlib-js/reviewers