feat: add `math/base/special/cphasef` #7158

anandkaranubc · 2025-06-01T15:57:46Z

Progresses #649

Description

What is the purpose of this pull request?

This pull request:

Adds the complete implementation for math/base/special/cphasef

Related Issues

Does this pull request have any related issues?

This pull request:

Progresses [RFC]: Add C implementations to base special math functions (tracking issue) #649

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

stdlib-bot · 2025-06-01T15:59:45Z

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/cphasef	$\color{green}138/138$ $\color{green}+100.00\%$	$\color{green}5/5$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}138/138$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: passed - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

Planeshifter · 2025-06-11T02:42:57Z

lib/node_modules/@stdlib/math/base/special/cphasef/README.md

+        v = x[ i ];
+        y = stdlib_base_cphasef( v );
+        stdlib_complex64_reim( v, &re, &im );
+        printf( "fcphasef(%f + %fi) = %f\n", re, im, y );


Was this supposed to be

Suggested change

printf( "fcphasef(%f + %fi) = %f\n", re, im, y );

printf( "cphasef(%f + %fi) = %f\n", re, im, y );

(also notice that JS example above has arg)?

Same question applies to example.c file.

That was being used in cphase, but I can revisit that and update it too.

stdlib/lib/node_modules/@stdlib/math/base/special/cphase/examples/index.js

Line 30 in 0160d55

console.log( 'arg(%s) = %d', z.toString(), cphase( z ) );

stdlib/lib/node_modules/@stdlib/math/base/special/cphase/examples/c/example.c

Line 41 in 0160d55

printf( "fcphase(%lf + %lfi) = %lf\n", re, im, y );

I think that has to be a typo. The README.md of cphase uses cphase:

https://github.com/stdlib-js/stdlib/tree/0160d55258f7e58e3e9bb2ad1a2c345575343515/lib/node_modules/%40stdlib/math/base/special/cphase

Should I also move forward and do the same changes in cphase as done here?

Yes, that would be great!

Planeshifter · 2025-06-11T02:44:07Z

lib/node_modules/@stdlib/math/base/special/cphasef/benchmark/c/benchmark.c

+		re[ i ] = ( 1000.0f*rand_float() ) - 500.0f;
+		im[ i ] = ( 1000.0f*rand_float() ) - 500.0f;


Can we generate the numbers via a random_uniform function, please?

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: passed - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

anandkaranubc · 2025-06-11T02:57:33Z

I used log-each-map for the JS examples to be consistent with the other examples. https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/math/base/special/cinvf/examples/index.js

Planeshifter

Let's get it in! Thanks, Karan!

stdlib-bot · 2025-06-11T02:59:34Z

PR Commit Message

feat: add `math/base/special/cphasef`

PR-URL: https://github.com/stdlib-js/stdlib/pull/7158
Ref: https://github.com/stdlib-js/stdlib/issues/649

Reviewed-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

⚠️ Action Required: This PR references tracking issues. Please update the PR description to replace any "Closes", "Fixes", or "Resolves" keywords with "Ref" when referencing these issues.

anandkaranubc added 3 commits May 24, 2025 00:23

feat: add math/base/special/cphasef

7293c7b

Merge branch 'develop' into feat/cphasef

b15bec3

stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Jun 1, 2025

anandkaranubc added Feature Issue or pull request for adding a new feature. JavaScript Issue involves or relates to JavaScript. C Issue involves or relates to C. GSoC Google Summer of Code. gsoc: 2025 Google Summer of Code (2025). labels Jun 1, 2025

anandkaranubc mentioned this pull request Jun 2, 2025

Weekly Standup (2025-06-02) stdlib-js/google-summer-of-code#156

Closed

Planeshifter reviewed Jun 11, 2025

View reviewed changes

anandkaranubc added 3 commits June 10, 2025 19:46

Merge branch 'develop' into feat/cphasef

8155509

Planeshifter approved these changes Jun 11, 2025

View reviewed changes

Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jun 11, 2025

stdlib-bot removed the Needs Review A pull request which needs code review. label Jun 11, 2025

Planeshifter merged commit 398ac1c into stdlib-js:develop Jun 11, 2025
29 checks passed

anandkaranubc deleted the feat/cphasef branch June 11, 2025 03:12

	printf( "fcphasef(%f + %fi) = %f\n", re, im, y );
	printf( "cphasef(%f + %fi) = %f\n", re, im, y );

		re[ i ] = ( 1000.0f*rand_float() ) - 500.0f;
		im[ i ] = ( 1000.0f*rand_float() ) - 500.0f;

Uh oh!

feat: add math/base/special/cphasef #7158

feat: add math/base/special/cphasef #7158

Uh oh!

Conversation

anandkaranubc commented Jun 1, 2025

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Jun 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Planeshifter Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc commented Jun 11, 2025

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Jun 11, 2025

PR Commit Message

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: add `math/base/special/cphasef` #7158

feat: add `math/base/special/cphasef` #7158

stdlib-bot commented Jun 1, 2025 •

edited

Loading

Planeshifter Jun 11, 2025 •

edited

Loading

Planeshifter Jun 11, 2025 •

edited

Loading