feat: add `math/base/special/sinf` #7229

anandkaranubc · 2025-06-06T01:51:07Z

Progresses #649

Description

What is the purpose of this pull request?

This pull request:

Adds the complete implementation for math/base/special/sinf

Related Issues

Does this pull request have any related issues?

This pull request:

Progresses [RFC]: Add C implementations to base special math functions (tracking issue) #649

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: passed - task: lint_c_examples status: passed - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

stdlib-bot · 2025-06-06T01:53:18Z

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/sinf	$\color{green}288/288$ $\color{green}+100.00\%$	$\color{green}25/25$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}288/288$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

anandkaranubc · 2025-06-06T01:54:02Z

lib/node_modules/@stdlib/math/base/special/sinf/package.json

+    "radians",
+    "angle"
+  ],
+  "__stdlib__": {


Added metadata too.

anandkaranubc · 2025-06-06T01:54:41Z

lib/node_modules/@stdlib/math/base/special/sinf/src/main.c

+/**
+* Computes the sine of a single-precision floating-point number (in radians).
+*
+* ## Method


I kept this comment because the same approach is used here too, like sin

anandkaranubc · 2025-06-06T01:56:26Z

lib/node_modules/@stdlib/math/base/special/sinf/test/test.js

+		x[ i ] = f32( x[ i ] );
+		expected[ i ] = f32( expected[ i ] );
+		y = sinf( x[ i ] );
+		t.strictEqual( y, expected[ i ], 'returns expected value' );


No need of approximate tests.

Signed-off-by: Karan Anand <[email protected]>

lib/node_modules/@stdlib/math/base/special/sinf/manifest.json

Signed-off-by: Philipp Burckhardt <[email protected]>

Planeshifter

Upon reflection, looks all fine to me!

stdlib-bot · 2025-06-09T14:29:03Z

PR Commit Message

feat: add `math/base/special/sinf`

PR-URL: https://github.com/stdlib-js/stdlib/pull/7229
Ref: https://github.com/stdlib-js/stdlib/issues/649

Co-authored-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Karan Anand <[email protected]>
Signed-off-by: Philipp Burckhardt <[email protected]>

Please review the above commit message and make any necessary adjustments.

⚠️ Action Required: This PR references tracking issues. Please update the PR description to replace any "Closes", "Fixes", or "Resolves" keywords with "Ref" when referencing these issues.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: passed - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

anandkaranubc · 2025-06-09T16:20:55Z

@Planeshifter Thanks for the review. I also made the changes to the C benchmarks.

Planeshifter

LGTM!

anandkaranubc added 3 commits June 5, 2025 15:23

feat: temp commit

17ea854

Merge branch 'develop' into feat/sinf

8c4d311

stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Jun 6, 2025

anandkaranubc commented Jun 6, 2025

View reviewed changes

anandkaranubc added 2 commits June 5, 2025 20:36

Update main.c

7db7935

Signed-off-by: Karan Anand <[email protected]>

Update main.c

0dfdd11

Signed-off-by: Karan Anand <[email protected]>

anandkaranubc mentioned this pull request Jun 9, 2025

Weekly Standup (2025-06-09) stdlib-js/google-summer-of-code#157

Closed

Planeshifter reviewed Jun 9, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/sinf/manifest.json Outdated Show resolved Hide resolved

Planeshifter reviewed Jun 9, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/sinf/manifest.json Outdated Show resolved Hide resolved

Planeshifter reviewed Jun 9, 2025

View reviewed changes

lib/node_modules/@stdlib/math/base/special/sinf/manifest.json Outdated Show resolved Hide resolved

fix: remove unused imports

ef366fc

Signed-off-by: Philipp Burckhardt <[email protected]>

This comment was marked as outdated.

Sign in to view

Planeshifter previously approved these changes Jun 9, 2025

View reviewed changes

Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jun 9, 2025

stdlib-bot removed the Needs Review A pull request which needs code review. label Jun 9, 2025

Merge branch 'develop' into feat/sinf

a1e3f7a

anandkaranubc dismissed Planeshifter’s stale review via f0303a0 June 9, 2025 16:20

anandkaranubc requested a review from Planeshifter June 9, 2025 16:21

stdlib-bot added the Needs Review A pull request which needs code review. label Jun 9, 2025

Planeshifter approved these changes Jun 9, 2025

View reviewed changes

Planeshifter merged commit c9f8cbe into stdlib-js:develop Jun 9, 2025
29 checks passed

stdlib-bot removed the Needs Review A pull request which needs code review. label Jun 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: add `math/base/special/sinf` #7229

feat: add `math/base/special/sinf` #7229

Uh oh!

anandkaranubc commented Jun 6, 2025

Uh oh!

stdlib-bot commented Jun 6, 2025 •

edited

Loading

Uh oh!

anandkaranubc Jun 6, 2025

Uh oh!

anandkaranubc Jun 6, 2025

Uh oh!

anandkaranubc Jun 6, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Planeshifter left a comment

Uh oh!

stdlib-bot commented Jun 9, 2025

Uh oh!

anandkaranubc commented Jun 9, 2025

Uh oh!

Planeshifter left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

feat: add math/base/special/sinf #7229

feat: add math/base/special/sinf #7229

Uh oh!

Conversation

anandkaranubc commented Jun 6, 2025

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

anandkaranubc Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

anandkaranubc Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

stdlib-bot commented Jun 9, 2025

PR Commit Message

Uh oh!

anandkaranubc commented Jun 9, 2025

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: add `math/base/special/sinf` #7229

feat: add `math/base/special/sinf` #7229

stdlib-bot commented Jun 6, 2025 •

edited

Loading