fix: update fromIndex handling in blas/ext/base/ndarray/dlast-index-of

[headlessNode]

---

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

• task: lint_filenames status: passed
• task: lint_editorconfig status: passed
• task: lint_markdown status: passed
• task: lint_package_json status: na
• task: lint_repl_help status: na
• task: lint_javascript_src status: passed
• task: lint_javascript_cli status: na
• task: lint_javascript_examples status: passed
• task: lint_javascript_tests status: passed
• task: lint_javascript_benchmarks status: passed
• task: lint_python status: na
• task: lint_r status: na
• task: lint_c_src status: na
• task: lint_c_examples status: na
• task: lint_c_benchmarks status: na
• task: lint_c_tests_fixtures status: na
• task: lint_shell status: na
• task: lint_typescript_declarations status: passed
• task: lint_typescript_tests status: na
• task: lint_license_headers status: passed ---

Progresses #2656.

Description

What is the purpose of this pull request?

This pull request:

• fix fromIndex handling in blas/ext/base/ndarray/dlast-index-of

Related Issues

Does this pull request have any related issues?

This pull request:

• progresses [RFC]: achieve ndarray API parity with built-in JavaScript arrays  #2656

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines.

---

@stdlib-js/reviewers

[stdlib-bot]

Coverage Report

Package	Statements	Branches	Functions	Lines
blas/ext/base/ndarray/dlast-index-of	$\color{green}138/138$ $\color{green}+100.00\%$	$\color{green}8/8$ $\color{green}+100.00\%$	$\color{green}1/1$ $\color{green}+100.00\%$	$\color{green}138/138$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

[headlessNode]

@kgryte I think only this function needed the change, blas/ext/base/dlast-index-of works as expected. And coming from top-level fromIndex will get resolved here.

[kgryte]

@headlessNode We'll also need to update slast-index-of, correct? https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/blas/ext/base/slast-index-of

[kgryte]

Other than the bounds checking behavior, this is shaping up. Once the bounds behavior is addressed, you should double-check that the tests are correct.

[kgryte]

LGTM after some minor clean-up.

[kgryte]

@headlessNode I believe we now need to update slast-index-of, correct?

[headlessNode]

@kgryte Yep.

[kgryte]

@headlessNode ...and glast-index-of. 😅