Skip to content

Conversation

Planeshifter
Copy link
Member

@Planeshifter Planeshifter commented Oct 13, 2025

Description

What is the purpose of this pull request?

This pull request:

  • configures no-restricted-syntax ESLint rule for source files (we have overrides for examples, test, and benchmark code where this should not apply) to enforce usage of stdlib packages over prototype methods and Node.js built-ins.

Related Issues

Does this pull request have any related issues?

None,

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@Planeshifter Planeshifter requested a review from kgryte October 13, 2025 06:13
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Oct 13, 2025
// String.prototype.trimStart / trimLeft
{
'selector': 'CallExpression[callee.property.name="trimStart"]',
'message': 'Use `@stdlib/string/base/left-trim` instead of String.prototype.trimStart.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to remember to update these messages once we have added the non-base packages.

Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding these @Planeshifter.

@kgryte kgryte added Tools Issue or pull request related to project tooling. and removed Needs Review A pull request which needs code review. labels Oct 13, 2025
@kgryte kgryte merged commit a3ed37a into develop Oct 13, 2025
54 checks passed
@kgryte kgryte deleted the philipp/eslint-enforce-stdlib-packages branch October 13, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tools Issue or pull request related to project tooling.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants