Skip to content

Polish experience tile layout with hover logo and cleaner list styling #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 12, 2025
Merged

Polish experience tile layout with hover logo and cleaner list styling #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e33c0ba
style: improve responsibilities list with cleaner bullet styling
steadyfall Apr 10, 2025
f65125c
feat: move company logo outside margins and reveal on hover
steadyfall Apr 10, 2025
af05bf6
refactor: rename isDesktop to isTablet for 768px breakpoint
steadyfall Apr 10, 2025
6979a7f
feat: make company logo backdrop transparent and adjust image size fo…
steadyfall Apr 10, 2025
cdab2c5
style: adjust spacing between - positions with/(out) responsibilities…
steadyfall Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/components/Education.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { useMediaQuery } from '@/hooks/useMediaQuery';
import { cn } from '@/lib/utils';

export function Education() {
const isDesktop = useMediaQuery('(min-width: 768px)');
const isTablet = useMediaQuery('(min-width: 768px)');
return (
<section id="education" className="mb-12">
<BlurFade delay={BLUR_FADE_DELAY * 7}>
Expand All @@ -25,12 +25,12 @@ export function Education() {
<img
src="/images/uwaterlooLogo.png"
alt={'University of Waterloo logo'}
width={isDesktop ? 80 : 45}
height={isDesktop ? 80 : 45}
width={isTablet ? 80 : 45}
height={isTablet ? 80 : 45}
className="rounded-md"
/>
</div>
<div className={'pl-16 ' + (isDesktop && 'py-3')}>
<div className={'pl-16 ' + (isTablet && 'py-3')}>
<div className="mb-2 flex flex-col justify-between sm:flex-row md:items-start">
<div>
<LinkWithArrow
Expand All @@ -46,13 +46,13 @@ export function Education() {
<h3 className="text-lg font-semibold">
Bachelor of Mathematics, Computational Mathematics Major
</h3>
{!isDesktop && (
{!isTablet && (
<h3 className="font-typewriter text-gray-600 dark:text-gray-400">
Sept 2022 - Present
</h3>
)}
</div>
{isDesktop && (
{isTablet && (
<h3 className="font-typewriter text-gray-600 dark:text-gray-400">
Sept 2022 - Present
</h3>
Expand Down
6 changes: 3 additions & 3 deletions src/components/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const Header = ({
email,
resumeFile,
}: HeaderProps) => {
const isDesktop = useMediaQuery('(min-width: 768px)');
const isTablet = useMediaQuery('(min-width: 768px)');
const [copied, setCopiedId] = useState<string>();
useEffect(() => {
setTimeout(() => {
Expand All @@ -44,7 +44,7 @@ const Header = ({
<div className="container mx-auto mb-10">
<div className="flex flex-col items-center justify-between md:flex-row">
<BlurFade delay={BLUR_FADE_DELAY}>
{!isDesktop && (
{!isTablet && (
<div className="mb-4 flex-shrink-0 md:mb-0 md:mr-8">
<img
src="/images/headshot.jpg"
Expand Down Expand Up @@ -145,7 +145,7 @@ const Header = ({
</div>
</div>
<BlurFade delay={BLUR_FADE_DELAY} inView={true}>
{isDesktop && (
{isTablet && (
<div className="flex-shrink-0">
<img
src="/images/headshot.jpg"
Expand Down
51 changes: 25 additions & 26 deletions src/components/Tiles/ExperienceTile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,28 +19,27 @@ export function ExperienceTile({
period,
responsibilities,
}: ExperienceTileProps) {
const isDesktop = useMediaQuery('(min-width: 768px)');
const isTablet = useMediaQuery('(min-width: 768px)');
const isDesktop = useMediaQuery('(min-width: 1280px)');
return (
<div
className={
(!(responsibilities && responsibilities.length > 0) && !isDesktop ? '-mb-6' : 'mb-6') +
' ' +
'flex items-center'
}
>
<div className="relative flex-grow md:pl-12">
<div className="absolute left-[5px] top-3 aspect-square rounded-lg bg-white">
{/* // center the bullet : `top-1/2 transform -translate-y-1/2` */}
<img
src={companyLogo}
alt={`${companyName} logo`}
width={isDesktop ? 80 : 45}
height={isDesktop ? 80 : 45}
className="rounded-md"
/>
</div>
<div className="py-3 pl-16">
<div className="mb-4 flex flex-col justify-between sm:flex-row md:items-start">
<div className="-mb-2 flex items-center">
<div className="group relative flex-grow lg:-ml-[132px] xl:-ml-40 2xl:-ml-52">
{isTablet && (
<div className="opacity-0 transition-opacity delay-100 md:group-hover:opacity-100">
<div className="absolute top-1/2 aspect-square -translate-y-1/2 transform rounded-lg bg-transparent">
{/* // center the bullet : `top-1/2 transform -translate-y-1/2` */}
<img
src={companyLogo}
alt={`${companyName} logo`}
width={isDesktop ? 80 : 70}
height={isDesktop ? 80 : 70}
className="rounded-md"
/>
</div>
</div>
)}
<div className="py-3 lg:pl-[132px] xl:pl-40 2xl:pl-52">
<div className="flex flex-col justify-between sm:flex-row md:items-start">
<div>
<h2 className="text-xl font-bold">{position}</h2>
<LinkWithArrow
Expand All @@ -51,19 +50,19 @@ export function ExperienceTile({
>
<h3 className="text-lg font-semibold">{companyName}</h3>
</LinkWithArrow>
{!isDesktop && (
{!isTablet && (
<h3 className="font-typewriter text-gray-600 dark:text-gray-400">{period}</h3>
)}
</div>
{isDesktop && (
{isTablet && (
<h3 className="font-typewriter text-gray-600 dark:text-gray-400">{period}</h3>
)}
</div>
{responsibilities && responsibilities.length > 0 && (
<div className="mt-4">
<ul className="list-inside space-y-1 text-gray-700 dark:text-gray-300">
<div className="mt-3">
<ul className="list-inside list-['-_'] space-y-1 text-gray-700 dark:text-gray-300">
{responsibilities.map((responsibility, index) => (
<li key={index}>- {responsibility}</li>
<li key={index}>{responsibility}</li>
))}
</ul>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/components/Tiles/ProjectTile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export function ProjectTile({
liveUrl,
techStack,
}: ProjectTileProps) {
// const isDesktop = useMediaQuery('(min-width: 768px)')
// const isTablet = useMediaQuery('(min-width: 768px)')
return (
<div className="items-center">
<div className="mb-2 flex flex-col justify-between sm:flex-row md:items-start">
Expand Down