[MultilineFunctionDeclaration] Make multiline in the middle #23
Conversation
| { | ||
| public function setFoo( | ||
| #[Beep] | ||
| Foo $new |
There was a problem hiding this comment.
Shouldn't this have a trailing comma
There was a problem hiding this comment.
Yes, and should also be fixed in the readme example and in the other fixed file
| elseif ( | ||
| !$tokensCollection->sameLine( | ||
| $tokensCollection->parenthesisOpener($stackPtr), | ||
| $tokensCollection->parenthesisCloser($stackPtr) |
| public function setFoo( | ||
| #[Beep] | ||
| Foo $new | ||
| ): void { |
There was a problem hiding this comment.
Isn't this wrong?
Perhaps the fixed version should only fix the single problem the test is testing?
There was a problem hiding this comment.
Yeah it is wrong.
The tests use all sniffs available, and even for the formatting, but since I don't have #35 merged yet I apparently missed this. I apparently just fixed it in the other test, not this one.
There was a problem hiding this comment.
Or wait, you weren't referring to the missing ,?
@bix0r what part is wrong with this one?
There was a problem hiding this comment.
I was actually referring to the empty method body. Isn't supposed to be: ): void {}. But yeah, I did miss the trailing comma :o
If a function is having multiple rows in the parameters, then nothing can be on the first row.
If a function is having multiple rows in the parameters, then nothing can be on the first row.
POC for #18