[MultilineFunctionDeclaration] Make multiline in the middle

README.md

@@ -29,6 +29,19 @@ class Example
 }
 ```
 
+Enforce multi row parameters to not be on the first row.
+Example:
+
+```php
+class Example
+{
+	public function test(
+		#[Attribute]
+		int $param,
+	)
+}
+```
+
 ### DocCommentSniff
 
 Allows some doc blocks to work as single line:

library.xml

@@ -113,4 +113,5 @@
 	<rule ref="SlevomatCodingStandard.Functions.RequireTrailingCommaInDeclaration"/>
 	<rule ref="SlevomatCodingStandard.Functions.RequireTrailingCommaInCall"/>
 	<rule ref="SlevomatCodingStandard.Arrays.DisallowImplicitArrayCreation"/>
+	<rule ref="SlevomatCodingStandard.Attributes.AttributeAndTargetSpacing"/>
 </ruleset>

src/Stefna/Sniffs/Functions/MultiLineFunctionDeclarationSniff.php

@@ -48,6 +48,23 @@ public function processSingleLineDeclaration(File $phpcsFile, int $stackPtr, arr
 				return;
 			}
 		}
+		elseif (
+			!$tokensCollection->sameLine(
+				$tokensCollection->parenthesisOpener($stackPtr),
+				$tokensCollection->parenthesisCloser($stackPtr),
+			)
+		) {
+			$parenthesisStart = $tokensCollection->parenthesisOpener($stackPtr);
+			$nextPtr = $phpcsFile->findNext(T_WHITESPACE, $parenthesisStart + 1, exclude: true);
+
+			if ($tokensCollection->sameLine($parenthesisStart, $nextPtr)) {
+				$error = 'Multiline function declarations can not start on the first line';
+				$fix = $phpcsFile->addFixableError($error, $nextPtr, 'MultilineNotPure');
+				if ($fix) {
+					$phpcsFile->fixer->addNewline($parenthesisStart);
+				}
+			}
+		}
 
 		parent::processSingleLineDeclaration($phpcsFile, $stackPtr, $tokens);
 	}

tests/Sniffs/Functions/MultiLineFunctionDeclarationSniffTest.php

@@ -22,4 +22,13 @@ public function testSingleLineWhitespace(): void
 
 		self::assertAllFixedInFile('OK');
 	}
+
+	public function testMultilineDeclaration(): void
+	{
+		$this->checkFile('MultilineDeclaration');
+
+		self::assertSniffError('MultilineNotPure', line: 7);
+
+		self::assertAllFixedInFile();
+	}
 }

tests/Sniffs/Functions/data/MultiLineFunctionDeclarationSniff/MultilineDeclaration.fixed.php

@@ -0,0 +1,12 @@
+<?php declare(strict_types=1);
+
+namespace StefnaTest\Sniffs\Functions\data\MultiLineFunctionDeclarationSniff;
+
+class MultilineDeclaration
+{
+	public function setFoo(
+		#[Beep]
+		Foo $new,
+	): void {
+	}
+}

tests/Sniffs/Functions/data/MultiLineFunctionDeclarationSniff/MultilineDeclaration.php

@@ -0,0 +1,10 @@
+<?php declare(strict_types=1);
+
+namespace StefnaTest\Sniffs\Functions\data\MultiLineFunctionDeclarationSniff;
+
+class MultilineDeclaration
+{
+	public function setFoo(#[Beep]
+	Foo $new,): void
+	{}
+}

tests/Sniffs/GeneralCodeStyle/FormattingTest.php

@@ -12,4 +12,11 @@ public function testFormatting(): void
 
 		self::assertAllFixedInFile(skipErrorCheck: true);
 	}
+
+	public function testAttributeMethodDeclaration(): void
+	{
+		$this->checkFile('AttributeMethodDeclaration');
+
+		self::assertAllFixedInFile(skipErrorCheck: true);
+	}
 }

tests/Sniffs/GeneralCodeStyle/data/Formatting/AttributeMethodDeclaration.fixed.php

@@ -0,0 +1,12 @@
+<?php declare(strict_types=1);
+
+namespace StefnaTest\Sniffs\GeneralCodeStyle\data\Formatting;
+
+class X
+{
+	public function setFoo(
+		#[Beep]
+		Foo $new,
+	): void {
+	}
+}

tests/Sniffs/GeneralCodeStyle/data/Formatting/AttributeMethodDeclaration.php

@@ -0,0 +1,10 @@
+<?php declare(strict_types=1);
+
+namespace StefnaTest\Sniffs\GeneralCodeStyle\data\Formatting;
+
+class X
+{
+	public function setFoo(#[Beep] Foo $new): void
+	{
+	}
+}