Fix builds when the image json is not compact #861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression in the build workflow where non-compact JSON input was being written to GITHUB_ENV, which only supports single-line values. The fix adds jq -c to compact the JSON before writing it to the environment.
- Adds JSON compacting step before writing to
GITHUB_ENV - Reorders debug output to show input before compacting
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6 tasks
fnando
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Compact the input json making it a single line for passing into the GITHUB_ENV that can only support single line, unless more complex scripting is used.
Why
I recently made a change to the build workflow that removed a line that ensured the JSON was compact. The bug doesn't affect builds in this repository because the images.json is always compacted onto a single line before it even gets to this step. But builds coming from other repositories are not, because this is the first step they see and where the compaction needs to happen.
Failing builds can be seen at: