Add quickstart CI workflows for pull requests #5058
Merged
+47
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds experimental GitHub Actions workflows to test stellar-core changes against quickstart environments on pull requests. The goal is to provide early feedback about potential breaking changes to downstream systems before merging code.
- Three workflows targeting different base images: testing, nightly, and nightly-next
- Each workflow builds stellar-core from the PR branch and runs quickstart integration tests
- Configured to run only on pull requests (not on push) since quickstart already runs nightly builds
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/quickstart-testing.yml |
Adds quickstart workflow for testing base image with protocol version 25 |
.github/workflows/quickstart-nightly.yml |
Adds quickstart workflow for nightly base image with protocol version 25 |
.github/workflows/quickstart-nightly-next.yml |
Adds quickstart workflow for nightly-next base image with protocol version 26 and horizon protocol check skip |
Member
Author
|
The new builds are failing due to a bug in Quickstart, which is being fixed in the following pull request: |
leighmcculloch
added a commit
to stellar/quickstart
that referenced
this pull request
Dec 10, 2025
### What Compact the input json making it a single line for passing into the GITHUB_ENV that can only support single line, unless more complex scripting is used. ### Why I recently made a change to the build workflow that removed a line that ensured the JSON was compact. The bug doesn't affect builds in this repository because the images.json is always compacted onto a single line before it even gets to this step. But builds coming from other repositories are not, because this is the first step they see and where the compaction needs to happen. Failing builds can be seen at: - stellar/stellar-core#5058 - https://github.com/stellar/stellar-core/actions/runs/20087758923/job/57628911263?pr=5058
This comment was marked as outdated.
This comment was marked as outdated.
leighmcculloch
force-pushed
the
add-quickstart-workflow-ci
branch
from
9efa995 to
5ecc3b6
Compare
Member
Author
|
@sisuresh I've rebased this pr and it's ready to review and merge. Also, I realised just now I accidentally opened this change on a local branch instead of a fork branch. Apologies for that. I didn't realise I had the ability to do that. |
sisuresh
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add three GitHub Actions workflows that build and test quickstart images on pull requests. Each workflow targets a different base image: testing, nightly, and nightly-next. The workflows build stellar-core from the PR branch and run quickstart built-in tests that check that the network is up, and other software components are ingesting and syncing, and that someone can do some payments (this happens via friendbot).
This change is an experiment to see if we get useful feedback about potential breakages to other downstream systems earlier in the development life cycle. The workflows only target pull requests and not push because the quick start repository already runs nightly builds of all software components' default branches.
The intent with running this on pull requests is that the repo does have long-lived pull requests from time to time. The goal is to give developers working on Stellar Core earlier feedback if changes they're making are likely to break downstream systems.
Failures in these builds, should not block merges. As we figure out how to best tune the build an to evaluate if it's value, if failures occur, they can be ignored, but would appreciate a comment in this slack channel.
The protocol default version config parameter in the change will be able to disappear after:
There is no issue for this change, but it was discussed prior here.
cc @sisuresh @anupsdf
Checklist
Ranclang-formatv8.0.0 (viamake formator the Visual Studio extension)CompilesRan all testsIf change impacts performance, include supporting evidence per the performance document