Allow filtering of group path #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathetos
reviewed
May 22, 2025
| 'prefix' => $is_using_asset_directory_prefix, | ||
| ]; | ||
| /** | ||
| * Allows for the group path to be filtered. |
There was a problem hiding this comment.
Maybe add a note here about how this handles custom wp-content folders better, so it doesn't get missed in the future?
Member
Author
There was a problem hiding this comment.
mathetos
approved these changes
May 22, 2025
mathetos
left a comment
mathetos
left a comment
There was a problem hiding this comment.
Thanks all for the quick work here!
JPry
reviewed
May 22, 2025
| * @param string $group_path_slug The slug of the group path. | ||
| */ | ||
| static::$group_paths[ $group_path_slug ] = apply_filters( | ||
| 'stellarwp/assets/group_path', |
Contributor
There was a problem hiding this comment.
@dpanta94 This filter is missing the hook prefix that is used by other filters in this library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a filter to allow external plugins to filter the group path being created