Skip to content

Allow filtering of group path #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpanta94 merged 4 commits into from
May 22, 2025
Merged

Allow filtering of group path #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bfefa0e
Allow filtering of group path
dpanta94 May 22, 2025
0193371
Version bump
dpanta94 May 22, 2025
0bea79b
align comment correctly
dpanta94 May 22, 2025
c65ccba
explanation message for the added filter
dpanta94 May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
/**
* Plugin Name: Assets
* Description: Asset library with a plugin bootstrap file for automated testing.
* Version: 1.4.8
* Version: 1.4.9
* Author: StellarWP
* Author URI: https://stellarwp.com
*/
27 changes: 22 additions & 5 deletions src/Assets/Config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,28 @@ public static function is_group_path_using_asset_directory_prefix( string $group
* @return void
*/
public static function add_group_path( string $group_path_slug, string $root, string $relative, bool $is_using_asset_directory_prefix = false ): void {
static::$group_paths[ $group_path_slug ] = [
'root' => self::normalize_path( $root ),
'relative' => trailingslashit( $relative ),
'prefix' => $is_using_asset_directory_prefix,
];
/**
* Allows for the group path to be filtered.
Copy link

@mathetos mathetos May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a note here about how this handles custom wp-content folders better, so it doesn't get missed in the future?

Copy link
Member Author

@dpanta94 dpanta94 May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathetos I did add a comment explaining how to use the filter. It's a shame that the library currently at least is unable of handling such issues itself.

As you can see here when plugins (like TEC suite plugins) are using the library they have to utilize the filter to ensure symlinks are followed.

*
* This filters allows plugins/themes using the library to modify the root path
* to follow symlinks. The library itself can't handle this on its own,
* because it's not possible to be aware of where the library is placed relative
* to the actual WordPress plugins or themes directories.
*
* @since 1.4.9
*
* @param array $group_path The group path data.
* @param string $group_path_slug The slug of the group path.
*/
static::$group_paths[ $group_path_slug ] = apply_filters(
'stellarwp/assets/group_path',
Copy link
Contributor

@JPry JPry May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dpanta94 This filter is missing the hook prefix that is used by other filters in this library.

[
'root' => self::normalize_path( $root ),
'relative' => trailingslashit( $relative ),
'prefix' => $is_using_asset_directory_prefix,
],
$group_path_slug
);
}

/**
Expand Down
Loading