Skip to content

revise: better error messages#5

Merged
claymcleod merged 3 commits intomainfrom
better-errors
Jun 6, 2025
Merged

revise: better error messages#5
claymcleod merged 3 commits intomainfrom
better-errors

Conversation

@claymcleod
Copy link
Member

@claymcleod claymcleod commented Jun 6, 2025

This PR adds better error messages through the use of thiserror and refining the language from some messages.

Before submitting this PR, please make sure:

For external contributors:

  • You have not used AI on any parts of this pull request.

For all contributors:

  • You have added a few sentences describing the PR here.
  • Your code builds clean without any errors or warnings.
  • You have added tests (when appropriate).
  • You have updated the README or other documentation to account for these changes (when appropriate).
  • You have added an entry to the relevant CHANGELOG.md (see "keep a changelog" for more information).
  • Your commit messages follow the conventional commit style.
  • Your PR title follows the conventional commit style.

@claymcleod claymcleod self-assigned this Jun 6, 2025
@github-actions
Copy link

github-actions bot commented Jun 6, 2025

🐰 Bencher Report

Branchmain
Testbedgithub-actions

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
contig::new📈 view plot
⚠️ NO THRESHOLD
11.21 ns
coordinates::interbase::try_new📈 view plot
⚠️ NO THRESHOLD
20.14 ns
intervals::interbase::try_new📈 view plot
⚠️ NO THRESHOLD
53.81 ns
positions::base::checked_add📈 view plot
⚠️ NO THRESHOLD
4.34 ns
positions::base::checked_sub📈 view plot
⚠️ NO THRESHOLD
2.80 ns
positions::base::try_new📈 view plot
⚠️ NO THRESHOLD
0.31 ns
positions::interbase::checked_add📈 view plot
⚠️ NO THRESHOLD
1.87 ns
positions::interbase::checked_sub📈 view plot
⚠️ NO THRESHOLD
0.62 ns
positions::interbase::new📈 view plot
⚠️ NO THRESHOLD
0.31 ns
🐰 View full continuous benchmarking report in Bencher

@claymcleod claymcleod merged commit 63be2b2 into main Jun 6, 2025
8 checks passed
@claymcleod claymcleod deleted the better-errors branch June 6, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant