feat: re-implement retry based on tokio_retry2.#21
Merged
peterhuene merged 4 commits intostjude-rust-labs:mainfrom Aug 20, 2025
Merged
feat: re-implement retry based on tokio_retry2.#21peterhuene merged 4 commits intostjude-rust-labs:mainfrom
tokio_retry2.#21peterhuene merged 4 commits intostjude-rust-labs:mainfrom
Conversation
This commit updates dependencies and fixes a few unnecessary dependencies. It also removes the retry functionality based on `reqwest-retry` as the crate is now significantly out of date and hasn't had anyone respond to requests to release a new version in some time.
This commit re-implements the retry feature on top of `tokio_retry2`.
Contributor
Author
|
FYI: the motivation for this change was seeing very old (and some packages with advisories) being transitively referenced through As the |
claymcleod
reviewed
Aug 20, 2025
claymcleod
approved these changes
Aug 20, 2025
Make the connect and read timeouts configurable on the builder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-implements the retry feature on top of
tokio_retry2.Removes the dependency on
reqwest-retryas it doesn't seem to be currently maintained and has dependencies that are quite outdated.Also fixes an infinite timeout for connecting and reading from the underlying
reqwest::Client.Before submitting this PR, please make sure:
changes (when appropriate).
CHANGELOG.md(see"keep a changelog" for more information).