Skip to content

fix: fix deserialization of cancel_task response.#22

Merged
peterhuene merged 4 commits intostjude-rust-labs:mainfrom
peterhuene:fix-cancel-task
Jan 8, 2026
Merged

fix: fix deserialization of cancel_task response.#22
peterhuene merged 4 commits intostjude-rust-labs:mainfrom
peterhuene:fix-cancel-task

Conversation

@peterhuene
Copy link
Contributor

@peterhuene peterhuene commented Jan 7, 2026

This corrects the expected response type from the cancel_task request.

The TES API specifies an empty JSON object be returned as a result of a successful request; the current implementation was expecting it to deserialize a unit tuple instead.

Before submitting this PR, please make sure:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • Your code builds clean without any errors or warnings.
  • You have added tests (when appropriate).
  • You have updated the README or other documentation to account for these
    changes (when appropriate).
  • You have added an entry to the relevant CHANGELOG.md (see
    "keep a changelog" for more information).
  • Your commit messages follow the conventional commit style.

This corrects the expected response type from the `cancel_task` request.

The TES API specifies an empty JSON object be returned as a result of a
successful request; the current implementation was expecting it to deserialize
a unit tuple instead.
@peterhuene peterhuene requested a review from claymcleod January 7, 2026 23:03
@peterhuene peterhuene self-assigned this Jan 7, 2026
Copy link
Member

@claymcleod claymcleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a gnarly one.

@peterhuene peterhuene merged commit f8a143f into stjude-rust-labs:main Jan 8, 2026
6 checks passed
@peterhuene peterhuene deleted the fix-cancel-task branch January 8, 2026 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants