fix: return response even if error occurs while decoding agent message

[alanshaw]

Return the repsonse even when an error occurs decoding the agent message. This allows a client to inspect the status code, headers and body, which may contain clues to why the failure happened.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
client/retrieval/connection.go	0.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
client/retrieval/connection.go	57.43% <0.00%> (ø)

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[volmedo]

Ok, although inspecting anything beyond the error when the error is not nil feels quite weird in Go.

A more idiomatic alternative would be to define an error type such as:

type ResponseDecodingError struct {
    msg  string
    resp transport.HTTPResponse
}

func (rde *ResponseDecodingError) Error() string {
    return rde.msg
}

func (rde *ResponseDecodingError) Response() transport.HTTPResponse {
    return rde.resp
}

Then the client could do error.As and fetch the response that failed to decode.

Just a non-blocking suggestion.

[Peeja]