Skip to content

fix: return response even if error occurs while decoding agent message #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alanshaw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: return response even if error occurs while decoding agent message #82

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/retrieval/connection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ func Execute(ctx context.Context, inv invocation.Invocation, conn client.Connect

output, err := conn.Codec().Decode(response)
if err != nil {
return nil, nil, fmt.Errorf("decoding message: %w", err)
return nil, response, fmt.Errorf("decoding message: %w", err)
}

return client.ExecutionResponse(output), response, nil
Expand Down